Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DB Browser for SQLite 3.11.2 #503

Merged
1 commit merged into from Jul 20, 2020
Merged

Add DB Browser for SQLite 3.11.2 #503

1 commit merged into from Jul 20, 2020

Conversation

chausner
Copy link
Contributor

@chausner chausner commented May 20, 2020 •
edited by ghost

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Binary-Validation-Error Indicates and error was encountered during InstallerScan test. label May 20, 2020
@ghost
Copy link

ghost commented May 20, 2020

chausner The package manager bot determined there was an issue with one of the installers listed in the url field, and cannot continue.

Here are some common causes for this failure you should consider:

  1. The Sha256 HASH in the manifest does not match the HASH of the installer. Run winget hash to generate the hash.
  2. The URL is not valid. Make sure the URL to the installer is publicly available and valid.
  3. The installer has been identified as malware. If the installer is detected as malware, you can submit the installer to the defender team for analysis as a potential false positive.

@chausner
Copy link
Contributor Author

/AzurePipelines run

@ghost ghost removed the Needs: author feedback label May 20, 2020
@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 503 in repo microsoft/winget-pkgs

@chausner chausner mentioned this pull request May 20, 2020
Closed
@NathanBnm NathanBnm mentioned this pull request May 21, 2020
Closed
@Teraskull Teraskull mentioned this pull request May 26, 2020
Closed
@KevinLaMS
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@KevinLaMS KevinLaMS removed the Binary-Validation-Error Indicates and error was encountered during InstallerScan test. label Jul 18, 2020
@wingetbot wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label Jul 18, 2020
@ghost ghost assigned KevinLaMS Jul 18, 2020
@ghost
Copy link

ghost commented Jul 18, 2020

This submission has moved to manual review.

@KevinLaMS KevinLaMS added the Validation-Completed Validation passed label Jul 20, 2020
@ghost
Copy link

ghost commented Jul 20, 2020

Hello @KevinLaMS!

Because this pull request has the Validation-Completed label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

ghost
ghost approved these changes Jul 20, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validation has completed

@ghost ghost merged commit dbda25b into microsoft:master Jul 20, 2020
@chausner chausner deleted the dbbrowserforsqlite branch April 1, 2021 17:21
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees

@KevinLaMS KevinLaMS

Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chausner @wingetbot @KevinLaMS