Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finebits Metro Commander app added #621

Merged
1 commit merged into from
Jul 17, 2020
Merged

Finebits Metro Commander app added #621

1 commit merged into from
Jul 17, 2020

Conversation

ValeraFinebits
Copy link
Contributor

@ValeraFinebits ValeraFinebits commented May 21, 2020 •
edited by ghost
Loading

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label May 21, 2020
@ghost ghost assigned KevinLaMS May 21, 2020
@ghost
Copy link

ghost commented May 21, 2020

This submission has moved to manual review.

@KevinLaMS KevinLaMS added the Blocking-Issue Manifest validation is blocked by a known issue. label May 21, 2020
@KevinLaMS
Copy link
Contributor

This is blocked because we do not have a the ability to pull in dependencies
It will not install if the framework is not there.

@ValeraFinebits
Copy link
Contributor Author

This is blocked because we do not have a the ability to pull in dependencies
It will not install if the framework is not there.

@KevinLaMS, how I can fix it?

@KevinLaMS
Copy link
Contributor

Greetings. This package fails because it is dependent on some frameworks, and we do not support the dependencies yet. microsoft/winget-cli#163

In the meantime, if you include the dependencies in your package, it should pass. Thanks.
From what I can tell, you need Microsoft.Services.Store.Engagement. If you need further instructions, do not hesitate to ping me.

@ValeraFinebits
Copy link
Contributor Author

Looks like I can't add Microsoft.Services.Store.Engagement

MakeAppx : error: Error info: error 80080204: The package with file name "Microsoft.Services.Store.Engagement_10.0.19011.0_arm__8wekyb3d8bbwe.appx" and package full name "Microsoft.Services.Store.Engagement_10.0.19011.0_arm__8wekyb3d8bbwe" is not valid in the bundle because it's a framework package.
MakeAppx : error: Bundle creation failed.

@KevinLaMS KevinLaMS added the Validation-MSIX-Dependency This label indicates that the MSIX has a dependency that is not filled. label May 26, 2020
@KevinLaMS KevinLaMS added the Validation-Completed Validation passed label Jul 17, 2020
@ghost
Copy link

ghost commented Jul 17, 2020

Hello @KevinLaMS!

Because this pull request has the Validation-Completed label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

ghost
ghost approved these changes Jul 17, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validation has completed

@ghost ghost merged commit 923aa9b into microsoft:master Jul 17, 2020
@ValeraFinebits ValeraFinebits deleted the mcapp branch June 4, 2021 06:49
@OfficialEsco OfficialEsco mentioned this pull request Jun 20, 2021
Closed
5 tasks
seejdev pushed a commit to seejdev/winget-pkgs that referenced this pull request Nov 4, 2021
@JohnMcPMS
Remove quotes from booleans (microsoft#621)
5d3193d
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees

@KevinLaMS KevinLaMS

Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Blocking-Issue Manifest validation is blocked by a known issue. Validation-Completed Validation passed Validation-MSIX-Dependency This label indicates that the MSIX has a dependency that is not filled.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ValeraFinebits @wingetbot @KevinLaMS @finebits-github