Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed incorrect version number for SQL Server Management Studio version 15.0.18330.0. #9362

Merged
1 commit merged into from
Mar 30, 2021
Merged

Fixed incorrect version number for SQL Server Management Studio version 15.0.18330.0. #9362

1 commit merged into from
Mar 30, 2021

Conversation

jedieaston
Copy link
Contributor

@jedieaston jedieaston commented Mar 30, 2021 •
edited
Loading

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate , where is the name of the manifest you're submitting?
  • Have you tested your manifest locally with winget install -m ?

Per microsoft/winget-cli#828, not using the build number for the version number causes winget to believe there's an update when there isn't one.

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label Mar 30, 2021
@ghost ghost assigned denelon Mar 30, 2021
@ghost
Copy link

ghost commented Mar 30, 2021

This submission has moved to manual review.

@KevinLaMS KevinLaMS added the Validation-Completed Validation passed label Mar 30, 2021
@ghost
Copy link

ghost commented Mar 30, 2021

Hello @KevinLaMS!

Because this pull request has the Validation-Completed label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

ghost
ghost approved these changes Mar 30, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validation has completed

@ghost ghost merged commit 2effb78 into microsoft:master Mar 30, 2021
@jedieaston jedieaston deleted the ssms-15.0.18330.0 branch March 30, 2021 12:55
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees

@denelon denelon

Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jedieaston @wingetbot @KevinLaMS @denelon