Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: wagoodman.dive version 0.10.0 #95634

Conversation

Okeanos
Copy link
Contributor

@Okeanos Okeanos commented Feb 4, 2023

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Validation-Installation-Error Error installing application label Feb 4, 2023
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Okeanos Okeanos changed the title New version: wagoodman.dive version 0.10.0 New package: wagoodman.dive version 0.10.0 Feb 4, 2023
@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Executable-Error labels Feb 4, 2023
@Okeanos
Copy link
Contributor Author

Okeanos commented Feb 10, 2023

Probably a victim of #95543?

@denelon
Copy link
Contributor

denelon commented Feb 10, 2023

I don't think so. Do you have a screenshot showing the output from "dive" after installing the package?

@Okeanos
Copy link
Contributor Author

Okeanos commented Feb 10, 2023

Sure: Screenshots attached:

Screenshot 2023-02-10 at 22 43 39

Screenshot 2023-02-10 at 22 47 27

If you need I can also provide screenshots of dive in action, however, as a demonstration that installation from the provided manifest works as expected the screenshots above should suffice.

@denelon
Copy link
Contributor

denelon commented Feb 10, 2023

With the default execution of "dive" it may be returning a non-zero exit code as it expects input. That's the most likely reason validation would fail. Now that we know the "dive --version" argument provides functional output (as long as the return code is 0) then we should be able to perform a manual validation.

@Okeanos
Copy link
Contributor Author

Okeanos commented Feb 10, 2023

That totally makes sense … d'oh.

Screenshot 2023-02-10 at 23 12 22

@Okeanos
Copy link
Contributor Author

Okeanos commented Feb 10, 2023

Should I patch the manifest to include a value for InstallerSuccessCodes (1 in this case)?

@Trenly
Copy link
Contributor

Trenly commented Feb 10, 2023

Should I patch the manifest to include a value for InstallerSuccessCodes (1 in this case)?

No, since the installer success code is different than the runtime success code which causes the executable error

@stephengillie
Copy link
Collaborator

@wingetbot waivers Add Validation-Installation-Error Validation-Executable-Error

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label Feb 13, 2023
@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Feb 13, 2023
@microsoft-github-policy-service
Copy link
Contributor

wingetbot,

The check-in policies require a moderator to approve PRs from the community.

Our moderators are community volunteers, please be patient and allow them sufficient time to review your submission.

Template: msftbot/requiresApproval/moderator

@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Feb 14, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 625c36d into microsoft:master Feb 14, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello microsoft-github-policy-service[bot],
Validation has completed.

Template: msftbot/validationCompleted

@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Publish-Pipeline-Succeeded Validation-Completed Validation passed Waived-Validation-Executable-Error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants