-
Notifications
You must be signed in to change notification settings - Fork 617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change how source codes (C#/XAML) are displayed #1535
Comments
I've learned that Pivot is deprecated, but SelectorBar is almost identical. |
@karkarl I think this makes sense? We do the same thing in the Windows Community Toolkit Gallery: |
Let's do it! I like the idea of aligning design patterns with Community toolkit. |
karkarl
pushed a commit
that referenced
this issue
Jun 12, 2024
<!--- Provide a general summary of your changes in the Title above --> related to #1535 Full Code (Xaml/C#) ![00002](https://github.com/microsoft/WinUI-Gallery/assets/9213496/e3e8d37f-089f-4220-96ee-b3e48c79fa26) Single Code (Xaml Only) ![00001](https://github.com/microsoft/WinUI-Gallery/assets/9213496/b411528b-b79e-4f1f-9ba8-f42edab66fa9) ## Description ## Motivation and Context ## How Has This Been Tested? Tested on my Laptop ## Screenshots (if appropriate): ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) --------- Co-authored-by: Jay <65828559+Jay-o-Way@users.noreply.github.com>
karkarl
pushed a commit
that referenced
this issue
Jul 15, 2024
<!--- Provide a general summary of your changes in the Title above --> related to #1535 Full Code (Xaml/C#) ![00002](https://github.com/microsoft/WinUI-Gallery/assets/9213496/e3e8d37f-089f-4220-96ee-b3e48c79fa26) Single Code (Xaml Only) ![00001](https://github.com/microsoft/WinUI-Gallery/assets/9213496/b411528b-b79e-4f1f-9ba8-f42edab66fa9) ## Description ## Motivation and Context ## How Has This Been Tested? Tested on my Laptop ## Screenshots (if appropriate): ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) --------- Co-authored-by: Jay <65828559+Jay-o-Way@users.noreply.github.com>
karkarl
pushed a commit
that referenced
this issue
Jul 15, 2024
<!--- Provide a general summary of your changes in the Title above --> related to #1535 Full Code (Xaml/C#) ![00002](https://github.com/microsoft/WinUI-Gallery/assets/9213496/e3e8d37f-089f-4220-96ee-b3e48c79fa26) Single Code (Xaml Only) ![00001](https://github.com/microsoft/WinUI-Gallery/assets/9213496/b411528b-b79e-4f1f-9ba8-f42edab66fa9) ## Description ## Motivation and Context ## How Has This Been Tested? Tested on my Laptop ## Screenshots (if appropriate): ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) --------- Co-authored-by: Jay <65828559+Jay-o-Way@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Issue type
enhancement
Which version of the app?
WinUI 3 Gallery
Description
Currently displaying codes is too long and confusing.
Using Pivot/selector bar can shorten the code and make it easier to use.
this Currently design
![image](https://private-user-images.githubusercontent.com/9213496/328974965-22da81d1-cf93-40ff-b70c-fc878f4998ba.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjI3MzY4OTcsIm5iZiI6MTcyMjczNjU5NywicGF0aCI6Ii85MjEzNDk2LzMyODk3NDk2NS0yMmRhODFkMS1jZjkzLTQwZmYtYjcwYy1mYzg3OGY0OTk4YmEucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDgwNCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA4MDRUMDE1NjM3WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MTBmMmI2YjRjYTFmMzNmMWFiZjZhZGU2MmQ0NTIyODBiODdiYmU2OWU5NDc3YWZmM2UyMDMyZDRhNzVjMGU5NCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.QpEYLDesVQn9cQjxL6FCeFZrggvDxNKtJwrMKy-pm1A)
I have used pivot for my app and it is as follows
![Screenshot 2024-05-08 203240](https://private-user-images.githubusercontent.com/9213496/328975859-6aa5fd92-6c5f-4414-b0ad-35271b553c9c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjI3MzY4OTcsIm5iZiI6MTcyMjczNjU5NywicGF0aCI6Ii85MjEzNDk2LzMyODk3NTg1OS02YWE1ZmQ5Mi02YzVmLTQ0MTQtYjBhZC0zNTI3MWI1NTNjOWMucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDgwNCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA4MDRUMDE1NjM3WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZjZkZDlhNzE2YTM2NTM1NjMwY2QyZjE0MTM4NTk3YTIwNjIwMjNjYzc3MzE3OTcxOWJiNjgwNjAwYTI5ZGVjMyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.6_XXL1weSoffOPe9M541W46zUom9tbQsU75_hvugE-w)
@karkarl If approved, I can create a PR for this.
Screenshots
No response
Windows version
Insider Build (xxxxx), Windows 11 24H2 (26052), Windows 11 23H2 (22631), Windows 11 22H2 (22621), Windows 11 21H2 (22000), Windows 10 22H2 (19045), November 2021 Update/21H2 (19044), May 2021 Update/21H1 (19043), October 2020 Update/20H2 (19042), October 2018 Update/RS5 (17763)
Additional context
No response
The text was updated successfully, but these errors were encountered: