Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NETCore projects should include TargetFramework property #67

Closed
rido-min opened this issue Dec 5, 2018 · 0 comments · Fixed by #90
Closed

NETCore projects should include TargetFramework property #67

rido-min opened this issue Dec 5, 2018 · 0 comments · Fixed by #90

Comments

@rido-min
Copy link
Member

rido-min commented Dec 5, 2018 •
edited

#66 removed TargetFrameworks . Project files should keep netcoreapp3.0 in the TargetFramework property.

Having the TargetFramework property in Directory.Build.props makes the projects not valid to open without the main solution. This is a problem since the repo has 200+ projects and waiting to load/build all to see a small project is defeating the purpose of this samples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixing build break due to new SDK microsoft/WPF-Samples
1 participant
@rido-min