Fixing build break due to new SDK #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vatsan-madhavan
approved these changes
Jun 14, 2019
| @@ -2,6 +2,7 @@ | |||
| <Project ToolsVersion="14.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | |||
| <Import Project="$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props" Condition="Exists('$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props')" /> | |||
| <PropertyGroup> | |||
| <TargetFrameworkVersion Condition="!$(MSBuildProjectName.Contains('netcore'))">v4.7.2</TargetFrameworkVersion> | |||
There was a problem hiding this comment.
We don’t need the condition anymore
There was a problem hiding this comment.
Same note goes for other projects. The condition was useful in a props file. In the csproj, there is no need for it.
There was a problem hiding this comment.
I removed the condition from all csproj files.
rladuca
approved these changes
Jun 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change modified netcore project files to contain property values to build properly such as
<UseWPF>true</UseWPF>and<EnableDefaultItems>false</EnableDefaultItems>.This change also moved
TargetFramework/TargetFrameworkVersionproperties into the individual netcore/net framework project files instead of Directory.Build.props. This should allow us to build each project individually.This change also moved conditional
Reference Includeneeded for multi-targeting from individual project files to the Directory.Build.props.Fixes #89, Fixes #67