Relax assert for detached XSKs in RX bypass #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csujedihy
reviewed
Feb 16, 2023
| @@ -1635,7 +1635,7 @@ XdpProgramCanXskBypass( | |||
| Program->Rules[0].Match == XDP_MATCH_ALL && | |||
| Program->Rules[0].Action == XDP_PROGRAM_ACTION_REDIRECT && | |||
| Program->Rules[0].Redirect.TargetType == XDP_REDIRECT_TARGET_TYPE_XSK && | |||
| XskIsDatapathHandleQueueMatched(Program->Rules[0].Redirect.Target, RxQueue); | |||
| XskCanBypass(Program->Rules[0].Redirect.Target, RxQueue); | |||
There was a problem hiding this comment.
nit: inline XskCanBypass?
There was a problem hiding this comment.
The XSK struct is defined in the xsk.c file, so it's hard to inline without exposing XSKs to everyone.
There was a problem hiding this comment.
Unless you mean just provide a hint to the compiler?
There was a problem hiding this comment.
I'm going to merge this because my own testing is dependent on it, but I'm happy to follow up.
csujedihy
approved these changes
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm hit an assert in local spinxsk testing where an XSK was fully disconnected while the RX queue was in bypass mode. This is a legitimate scenario, so relax the constraints to allow disconnected XSKs on this code path.
Also, ensure asserts in CI/CD on debug builds cause the machine to bugcheck - apparently Windows may absorb assertions depending on the system config.