Add capabilities command to rssconfig #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nibanks
approved these changes
Oct 30, 2023
mtfriesen
approved these changes
Oct 31, 2023
|
Why are we adding this? Can we add a description to each PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rssconfig test tool commands leverage 2 (get config, set config) out of the 3 (get config, set config, get capabilities) main experimental RSS APIs. Add a command to leverage the third. This new command is helpful to see which adapters support RSS instead of guessing or using other methods outside of rssconfig.
Also fix a bug in rssconfig regarding XdpGetRoutine error checking.