Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve SAL for RSS APIs #417

Merged
merged 2 commits into from
Dec 2, 2023
Merged

Improve SAL for RSS APIs #417

merged 2 commits into from
Dec 2, 2023

Conversation

nigriMSFT
Copy link
Contributor

Resolves the following static analysis issues for a typical app that queries the required length for capabilities/configuration, allocates a buffer of that length, and gets the capabilities/configuration using that buffer.

error C6386: Buffer overrun while writing to 'RssCapabilities':  the writable size is 'RssCapabilitiesSize' bytes, but '28' bytes might be written.
error C6386: Buffer overrun while writing to 'RssConfig':  the writable size is 'RssConfigSize' bytes, but '24' bytes might be written.

@nigriMSFT nigriMSFT requested a review from a team as a code owner November 30, 2023 23:27
@nigriMSFT nigriMSFT merged commit f3194d3 into main Dec 2, 2023
45 checks passed
@nigriMSFT nigriMSFT deleted the nigriMSFT/sal branch December 2, 2023 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtfriesen mtfriesen mtfriesen approved these changes

@nibanks nibanks nibanks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nigriMSFT @mtfriesen @nibanks