Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uninstall eBPF using Uninstall-Package #470

Merged
merged 2 commits into from
Feb 20, 2024

Conversation

mtfriesen
Copy link
Contributor

To attempt to make eBPF uninstall more resilient to various errors, uninstall using Uninstall-Package if the local MSI uninstall failed.

@mtfriesen mtfriesen added the ebpf label Feb 20, 2024
@mtfriesen mtfriesen requested a review from a team as a code owner February 20, 2024 16:41
@mtfriesen mtfriesen enabled auto-merge (squash) February 20, 2024 16:42
@nibanks
Copy link
Member

nibanks commented Feb 20, 2024

netperf jobs still fail to remove eBPF:

====================SET UP====================

Copying files to peer...
Checking local machine state...
Detected ebpfcore.sys is loaded. Uninstalling ebpf...
Write-Error: C:\actions-runner\_work\netperf\netperf\tools\check-drivers.ps1:64
Line |
  64 |      Check-And-Remove-Driver "ebpfcore.sys" "ebpf"
     |      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     | ebpfcore.sys loaded!

@mtfriesen
Copy link
Contributor Author

netperf jobs still fail to remove eBPF:

Yeah, I'm not really surprised. I've seen plenty of cases on my own test machines where a bugcheck causes the eBPF MSI to be "not installed" but the eBPF service and driver are still installed, requiring manual steps (e.g. sc delete) to uninstall.

I am enabling verbose output in the netperf jobs so we can verify the behavior of the MSI changes here.

@mtfriesen mtfriesen merged commit ee15fbe into main Feb 20, 2024
42 of 45 checks passed
@mtfriesen mtfriesen deleted the mtfriesen/uninstall_ebpf_package branch February 20, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants