-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use test tools from win-net-test #477
Conversation
@@ -143,6 +143,28 @@ function Get-EbpfPackageUrl { | |||
return "https://github.com/microsoft/ebpf-for-windows/releases/download/Release-v" + $EbpfVersion + "/" + $EbpfPackageName | |||
} | |||
|
|||
function Get-FnVersion { | |||
return "0.4.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems painful to keep in-sync with the dependency. Is there no better way to have this somewhere more easily found?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I 100% agree. This is the pattern used for the eBPF dependency though (and the pattern used by the wtc project's consumption of fnmp), so its no worse off than how existing dependencies are handled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright. We can keep it as is for now. But I'm not a big fan. I'd prefer some top-level json file or something that lists the dependencies and version numbers. We can follow up later though.
Hmm the "Downlevel Functional Tests" are running a downlevel version of the test, but with the uplevel version of the test tool installation. This appears to cause an issue, since the test logic is hardcoded to expect the test adapter to have a certain InterfaceDescription/ifdesc (XDPFNMP) and the test adapters are now installed with a difference ifdesc (FNMP). |
Hmmm. How hard would it be to update the downlevel tests to allow for both? We then have to push a change to downlevel to fix. |
I might be able to change the ifdesc with a bit of a hack. Let me try that first |
Darn the hack in mind doesn't seem to work. I guess I can open a PR on the release 1.0 branch. The change should be pretty small and scoped to test code only. |
This reverts commit 891947f.
It is actually not as simple as a difference in ifdesc. The mp device name has also churned and the downlevel test code is compiled with xdpfnmpapi.lib which uses the old device name to communicate with the driver (xdpfnmp vs. fnmp). :( Maybe we should just merge this whole PR into downlevel as well? |
04a750e
to
6a9e703
Compare
Remove the xdpfnmp, xdpfnlwf and pkthlp test components and consume their equivalents from the win-net-test project.
Resolves #422