clean up pending NBLs in FNMP and FNLWF using RAII #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtfriesen
added
bug
nigriMSFT
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our functional tests can bugcheck if filtered NBLs are left pending in the FNMP/FNLWF. This happens if the test fails for some reason, causing an exception to be thrown and objects destructed. If the test cases don't have their handles declared extremely carefully, then an object (like an XDP program or XSK handle) might be destructed before the FNMP/FNLWF handle, causing an infinite hang.
Use the new win-net-test API to atomically clear the FNMP/FNLWF filters and return NBLs, and return an RAII object whenever a filter gets set.
Resolves #510
Also consumes a new bugfix for FNLWF that ensures its data path doesn't pause until all filtered RX frames are returned.