C++/WinRT support for non-WinRT error information #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennykerr
requested review from
BenJKuhn,
DefaultRyan and
Scottj1s
as code owners
Scottj1s
approved these changes
Sep 16, 2019
manodasanW
reviewed
Sep 16, 2019
| info->GetDescription(legacy.put()); | ||
| } | ||
|
|
||
| hstring message; |
There was a problem hiding this comment.
Consider if you get want to append GetGuid / GetSource to the message. Not sure how often they are used.
There was a problem hiding this comment.
Rarely in my experience, and then I'd have to worry about how to format it. 😨
manodasanW
approved these changes
Sep 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #580
C++/WinRT assumes error information is propagated using WinRT error origination APIs. This update ensures that APIs that only use the older
IErrorInfointerface for error reporting still get their error messages reported by C++/WinRT.