This repository has been archived by the owner on May 16, 2023. It is now read-only.
Updating Learn LTI backend to work with LTI 1 Protocol as well #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 7, 2020 13:30
…LTI 1.3. - LTI 1 does not map platform for assignments, hence, it is not possible to personalize them as per the LMS.
…API to work with LTI 1 - LtiLibrary was not able to parse the ContextRole for the member correctly. Updating to newer nuget version fixes the issue. - Also, updated the Connect Function to depend on our Lti1Binding as it was accidentally dependent on LtiLibrary nuget which should be a hidden dependency of our binding.
…de the client code
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Functional Changes
Current Learn-LTI backend was not functioning correctly with our Moodle Instance when onboarded via LTI 1. Below are the issues which needs to be handled before it could become functional again: -
Assignmentsin LTI 1 do not have platform information, hence, there's noPlatformsPersonalization possible for them. Guarding those changes inside the appropriateLtiVersioncheckUsersApi when querying members from LMS was returning204 NO DATAas it was not getting any members from that function. This was a bug in the parsing logic of underlying LtiLibrary. The issue requires us to update to a newer version of the Library which adds support for this parsing.Miscellaneous Changes
As a part of the PR, we are also making few logical changes listed below.
ConnectApi to depend onLTI1Bindinginstead of directly depending onLtiLibrary..envsettings for Service Urls to adhere to consistent Url handling in client code.