Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

Broken links #35

Closed
oyvindk opened this issue Jan 22, 2020 · 1 comment · Fixed by #36
Closed

Broken links #35

oyvindk opened this issue Jan 22, 2020 · 1 comment · Fixed by #36
Assignees

Comments

@oyvindk
Copy link

oyvindk commented Jan 22, 2020

The page at https://docs.microsoft.com/en-us/samples/microsoftgraph/aspnet-webhooks-rest-sample/microsoft-graph-aspnet-webhooks/ has some links to files in a repo that has been moved. The repo is now at https://github.com/microsoftgraph/aspnet-webhooks-rest-sample/tree/master/GraphWebhooks/. The broken links are under the heading "Key components of the sample".

@jasonjoh
Copy link
Member

Thanks @oyvindk. The first link you sent is apparently just publishing the README from this repo, which contains relative links to those files. They of course work when reading the README on GitHub. But during publication to Docs, they've made them relative to the docs.microsoft.com/samples site, which is broken. The easy fix here would be to remove the links or make them absolute, but I'm going to discuss with the folks implementing the sample browser to evaluate this problem. I can't imagine it's just this one sample :).

@jasonjoh jasonjoh self-assigned this Jan 22, 2020
jasonjoh added a commit that referenced this issue Feb 4, 2020
Removed links to files, which render broken on docs.microsoft.com

Fixes #35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants