This repository has been archived by the owner on Nov 16, 2023. It is now read-only.
Bring sample up to date #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jasonjoh
commented
May 22, 2018
jasonjoh
commented
- Replaced ADAL library (using Azure v1 endpoints) with MSAL (using Azure v2 endpoints)
- Replaced manual HTTP calls with Graph SDK
- UI updates (for new version of Bootstrap)
Fixing issues reported by markdownlint
Updated to latest packages
Moved sensitive settings (app ID, secret) to PrivateSettings.config and added that to .gitignore.
Remove and sort
We no longer need the GraphHttpClient class or the AuthHelper class. Also removed the hand-crafted Subscription and Message models, since Graph SDK provides those.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.