Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates PowerShell snippet Generator to handle encoded payload for $filter option #1530

Merged
merged 1 commit into from
May 4, 2023
Merged

Updates PowerShell snippet Generator to handle encoded payload for $filter option #1530

merged 1 commit into from
May 4, 2023

Conversation

timayabi2020
Copy link
Contributor

Overview

This PR fixes #1520
It ensures that the snippet returned does not have encoded payload for $filter option.

Generated snippet before fix

image

image

Generated snippet after fix

image

image

Testing Instructions

  • Checkout this branch , run it locally and use Postman to test using the examples on the postman screenshots

@timayabi2020 timayabi2020 linked an issue May 4, 2023 that may be closed by this pull request
Get-MgUserMessage_List1: Invalid filter clause #1520
Closed
@timayabi2020 timayabi2020 mentioned this pull request May 4, 2023
Closed
@timayabi2020 timayabi2020 changed the title Modified powershell generator to handle encoded strings Updates PowerShell snippet Generator to handle encoded payload for $filter option May 4, 2023
@sonarcloud
Copy link

sonarcloud bot commented May 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@timayabi2020 timayabi2020 merged commit a907845 into dev May 4, 2023
6 checks passed
@timayabi2020 timayabi2020 deleted the 1520-get-mgusermessage_list1-invalid-filter-clause branch May 4, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrueastman andrueastman andrueastman approved these changes

@irvinesunday irvinesunday Awaiting requested review from irvinesunday

@baywet baywet Awaiting requested review from baywet

@ddyett ddyett Awaiting requested review from ddyett

@MIchaelMainer MIchaelMainer Awaiting requested review from MIchaelMainer

@nikithauc nikithauc Awaiting requested review from nikithauc

@zengin zengin Awaiting requested review from zengin

@MaggieKimani1 MaggieKimani1 Awaiting requested review from MaggieKimani1

@fey101 fey101 Awaiting requested review from fey101

@adhiambovivian adhiambovivian Awaiting requested review from adhiambovivian

@danielmbaluka danielmbaluka Awaiting requested review from danielmbaluka

@rkodev rkodev Awaiting requested review from rkodev

@millicentachieng millicentachieng Awaiting requested review from millicentachieng

@peombwa peombwa Awaiting requested review from peombwa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get-MgUserMessage_List1: Invalid filter clause
2 participants
@timayabi2020 @andrueastman