Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update response for endpoint used to fetch permissions for a set of request URLs #1559

Merged
merged 10 commits into from
May 26, 2023
Merged

Update response for endpoint used to fetch permissions for a set of request URLs #1559

merged 10 commits into from
May 26, 2023

Conversation

millicentachieng
Copy link
Contributor

@millicentachieng millicentachieng commented May 17, 2023 •
edited

Overview

The update is to ensure consistent behaviour regardless of the content of the response.

{
  "results": [
    {
      "value": "string",
      "scopeType": "ScopeType",
      "consentDisplayName": "string",
      "consentDescription": "string",
      "isAdmin": "string",
      "leastPrivilegeOnly": "bool"
    }
  ],
  "errors": [
    {
      "requestUrl": "string",
      "message": "string"
    }
  ]
}

@millicentachieng millicentachieng changed the title Task/ma/update permissions response Update response for endpoint used to fetch permissions for a set of request URLs May 17, 2023
@millicentachieng millicentachieng marked this pull request as ready for review May 17, 2023 18:52
@millicentachieng millicentachieng requested a review from a team as a code owner May 17, 2023 18:53
@millicentachieng millicentachieng force-pushed the task/ma/update-permissions-response branch from b940c06 to 75855d8 Compare May 23, 2023 23:36
andrueastman
andrueastman reviewed May 24, 2023
View reviewed changes
UriMatchService/UriTemplateMatcher.cs Outdated Show resolved Hide resolved
PermissionsService/Services/PermissionsStore.cs Outdated Show resolved Hide resolved
UriMatchService/UriTemplateMatcher.cs Outdated Show resolved Hide resolved
UriMatchService/UriTemplateMatcher.cs Outdated Show resolved Hide resolved
UtilityService/UtilityExtensions.cs Outdated Show resolved Hide resolved
@millicentachieng millicentachieng force-pushed the task/ma/update-permissions-response branch from 27d0926 to 1a836c9 Compare May 26, 2023 08:20
@sonarcloud
Copy link

sonarcloud bot commented May 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@millicentachieng millicentachieng merged commit 07637cb into dev May 26, 2023
8 checks passed
@millicentachieng millicentachieng deleted the task/ma/update-permissions-response branch May 26, 2023 11:04
@millicentachieng millicentachieng linked an issue May 26, 2023 that may be closed by this pull request
[Bug] Permissions data cache will hold a null entry in case there's an exception fetching the data #1569
Closed
@millicentachieng millicentachieng mentioned this pull request May 26, 2023
Closed
@millicentachieng millicentachieng linked an issue May 26, 2023 that may be closed by this pull request
URL template matching in wrong in some cases #1568
Closed
@millicentachieng millicentachieng mentioned this pull request May 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irvinesunday irvinesunday irvinesunday left review comments

@andrueastman andrueastman andrueastman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@millicentachieng @andrueastman @irvinesunday