Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong quotes on string literals causing parse errors in PowerShell #1566

Merged
merged 7 commits into from
May 24, 2023
Merged

Fix wrong quotes on string literals causing parse errors in PowerShell #1566

merged 7 commits into from
May 24, 2023

Conversation

timayabi2020
Copy link
Contributor

Overview

Fixes #1326

Demo

Http Snippet
image

Expected PowerShell Snippet with the correct quotes
image

@timayabi2020 timayabi2020 requested a review from a team as a code owner May 23, 2023 11:12
@timayabi2020 timayabi2020 linked an issue May 23, 2023 that may be closed by this pull request
PowerShell string literals use wrong quotes #1326
Closed
@sonarcloud
Copy link

sonarcloud bot commented May 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@timayabi2020 timayabi2020 merged commit 92fb1fe into dev May 24, 2023
8 checks passed
@timayabi2020 timayabi2020 deleted the 1326-powershell-string-literals-use-wrong-quotes branch May 24, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrueastman andrueastman andrueastman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PowerShell string literals use wrong quotes
2 participants
@timayabi2020 @andrueastman