Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match path nodes with method on snippet generation #1570

Merged
merged 1 commit into from
May 24, 2023

Conversation

andrueastman
Copy link
Member

This PR updates the snippet generation logic to fail in the event at a path is found but the requested http method does not exist in the metadata to prevent the generation of methods that do not exist in snippets.

Changes have been benchmarked with the dev branch in the pipeline runs at the links below.
Dev - https://dev.azure.com/microsoftgraph/Graph%20Developer%20Experiences/_build/results?buildId=115361&view=ms.vss-test-web.build-test-results-tab&runId=1135195&resultId=100674&paneView=debug
This PR - https://dev.azure.com/microsoftgraph/Graph%20Developer%20Experiences/_build/results?buildId=115362&view=ms.vss-test-web.build-test-results-tab&runId=1135211&resultId=100115&paneView=debug

In summary, snippets generated will reduce by about 1% as summarized in the table below from the above runs,

Title Current rate New rate Change
V1 Go/C# 92.59% 91.63% 0.91%(23 snippets)
Beta Go/C# 91.15% 89.43 1.71% (63 snippets)

Note
Pass rates in compilation stages will therefore go up due to the failed compilation snippets now not being generated.

@andrueastman andrueastman requested a review from a team as a code owner May 24, 2023 09:11
@andrueastman andrueastman enabled auto-merge (squash) May 24, 2023 09:11
@andrueastman andrueastman self-assigned this May 24, 2023
@sonarcloud
Copy link

sonarcloud bot commented May 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@andrueastman andrueastman merged commit cab81f2 into dev May 24, 2023
26 checks passed
@andrueastman andrueastman deleted the andrueastman/failMissingMethod branch May 24, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants