Lookup QueryParameters from schema #1575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrueastman
force-pushed
the
andrueastman/snippetGenerationFixes
branch
from
372919b
to
044af6e
Compare
andrueastman
force-pushed
the
andrueastman/snippetGenerationFixes
branch
from
044af6e
to
d8878a5
Compare
|
Kudos, SonarCloud Quality Gate passed! |
rkodev
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
snippetCodeGraphto lookupqueryParametersfrom the reference schema/openapi file as opposed to using the naming from the input http request.This is will reduce errors in generation due to different casing and types as the generated builders will use the casing and types from the reference document.
https://learn.microsoft.com/en-us/graph/api/user-list-mailfolders?view=graph-rest-1.0&tabs=csharp
Also closes #1567 where filter clauses would have the filter statement in the event the filter statement involved a referencing nested property using the
/characterhttps://github.com/microsoftgraph/microsoft-graph-docs-contrib/issues/1184
Generation diff viewable at https://github.com/microsoftgraph/microsoft-graph-docs/compare/preview-snippet-generation/115791..preview-snippet-generation/115848?expand=1