Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create microsoft-graph-devx-api-branch-protection.yml #1582

Merged
merged 2 commits into from
Jun 9, 2023

Conversation

MIchaelMainer
Copy link
Contributor

Capture current policy state so that we can make versioned changes to branch protection policies. This will enable policy history, auditing, review, standardization, and templatization.

Capture current policy state so that we can make versioned changes  to branch protection policies. This will enable policy history, auditing, review, standardization, and templatization.
@MIchaelMainer MIchaelMainer requested a review from a team as a code owner June 1, 2023 22:26
@andrueastman
Copy link
Member

Just to confirm, do we want to merge the current policy states as is and resolve the reported flags in subsequent PRs?

4 invalid rules

  • RequiresStrictStatusChecks must be true when specifying RequiredStatusChecks.
  • At least one value under WhoCanDismissReviews must be specified when RestrictsReviewDismissals is true.
  • RequiresStrictStatusChecks must be true when specifying RequiredStatusChecks.
  • At least one value under WhoCanDismissReviews must be specified when RestrictsReviewDismissals is true.

Total execution time: 0.12 seconds

@MIchaelMainer
Copy link
Contributor Author

Not yet. I'm using this PR to make sure I export and generate the correct yaml file. I will follow up with this.

@MIchaelMainer
Copy link
Contributor Author

@andrueastman let's merge this. The rules checking the policy settings is incorrect. The policy settings are valid. I've opened an issue on this in the appropriate repo https://github.com/microsoft/GitOps.Branches/issues/72

@sonarcloud
Copy link

sonarcloud bot commented Jun 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@andrueastman andrueastman merged commit 71e431f into dev Jun 9, 2023
9 of 10 checks passed
@andrueastman andrueastman deleted the branchprotectionpolicy branch June 9, 2023 07:42
@microsoft-github-policy-service

3 invalid rules

  • RequiresStrictStatusChecks must be true when specifying RequiredStatusChecks.
  • RequiresStrictStatusChecks must be true when specifying RequiredStatusChecks.
  • At least one value under WhoCanDismissReviews must be specified when RestrictsReviewDismissals is true.

Total execution time: 0.15 seconds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants