Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return empty results array if no permissions found #1600

Merged
merged 3 commits into from
Jun 19, 2023
Merged

Return empty results array if no permissions found #1600

merged 3 commits into from
Jun 19, 2023

Conversation

millicentachieng
Copy link
Contributor

@millicentachieng millicentachieng commented Jun 19, 2023 •
edited

Overview

Fixes #1601
Returns empty results array if no permissions are found

{
    "results": [],
    "errors": [
        {
            "requestUrl": "/admin",
            "message": "Permissions information for 'GET /admin' was not found."
        }
     ]
}

@millicentachieng millicentachieng requested a review from a team as a code owner June 19, 2023 08:07
andrueastman
andrueastman previously approved these changes Jun 19, 2023
View reviewed changes
@millicentachieng @irvinesunday
Update GraphWebApi/Controllers/PermissionsController.cs
e52d0d6 
Co-authored-by: Irvine Sunday <40403681+irvinesunday@users.noreply.github.com>
@sonarcloud
Copy link

sonarcloud bot commented Jun 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@millicentachieng millicentachieng merged commit ff1f170 into dev Jun 19, 2023
9 checks passed
@millicentachieng millicentachieng deleted the task/ma/return-empty-result-array branch June 19, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irvinesunday irvinesunday irvinesunday approved these changes

@thewahome thewahome thewahome approved these changes

@andrueastman andrueastman Awaiting requested review from andrueastman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Return empty results array if no permissions found
4 participants
@millicentachieng @andrueastman @irvinesunday @thewahome