Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Use pascal case for issue property key #1603

Merged
merged 2 commits into from
Jun 19, 2023
Merged

Conversation

Onokaev
Copy link
Contributor

@Onokaev Onokaev commented Jun 19, 2023

Overview

Fixes #1602

Demo

Notes

Optional. Ancillary topics, caveats, alternative strategies that didn't work out, anything else.

Testing Instructions

  • How to test this PR
  • Prefer bulleted description
  • Start after checking out this branch
  • Include any setup required, such as bundling scripts, restarting services, etc.
  • Include test case, and expected output

Co-authored-by: Eastman <andrueastman@users.noreply.github.com>
@sonarcloud
Copy link

sonarcloud bot commented Jun 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Onokaev Onokaev merged commit b2d736a into dev Jun 19, 2023
9 checks passed
@Onokaev Onokaev deleted the fix/use-pascal-case branch June 19, 2023 14:12
andrueastman added a commit that referenced this pull request Jun 20, 2023
* Fix: Use pascal case for issue property key (#1603)

* Use pascal case for issue propety key

* Update GraphWebApi/Controllers/KnownIssuesController.cs

Co-authored-by: Eastman <andrueastman@users.noreply.github.com>

---------

Co-authored-by: Eastman <andrueastman@users.noreply.github.com>

* Lookup schema with discriminator in OpenAPI snippets (#1604)

* Use shared base to reduce code repetition

* Looks up dereived types from schema list

* Fixes template matching for collections with functions

* Fixes Guid parsing

* Fixes enum parsing in path parameters

* Fix incorrect schema names when looked up from collections

* Fix namespaces lookup for collections

* Fix code smells

* Bump Microsoft.OpenApi from 1.6.4 to 1.6.5 (#1606)

Bumps [Microsoft.OpenApi](https://github.com/Microsoft/OpenAPI.NET) from 1.6.4 to 1.6.5.
- [Release notes](https://github.com/Microsoft/OpenAPI.NET/releases)
- [Commits](microsoft/OpenAPI.NET@1.6.4...1.6.5)

---
updated-dependencies:
- dependency-name: Microsoft.OpenApi
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump Microsoft.OpenApi.Readers from 1.6.4 to 1.6.5 (#1605)

Bumps [Microsoft.OpenApi.Readers](https://github.com/Microsoft/OpenAPI.NET) from 1.6.4 to 1.6.5.
- [Release notes](https://github.com/Microsoft/OpenAPI.NET/releases)
- [Commits](microsoft/OpenAPI.NET@1.6.4...1.6.5)

---
updated-dependencies:
- dependency-name: Microsoft.OpenApi.Readers
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: EvansA <evansonoka05.j@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use PascalCase case for knownissues
3 participants