Decouple wiql from class instance #1609
Conversation
| { | ||
| _telemetryClient?.TrackTrace("Fetches a WorkItemQueryResult for fetching work item Ids and urls", | ||
| SeverityLevel.Information, | ||
| _knownIssuesTraceProperties); | ||
| this.IssuesEnvironment = environment; |
There was a problem hiding this comment.
I suspect you may have issues with this being an instance variable. As the KnownIssuesService is a singleton in the project.
When two simultaneous calls to the controller are made with different parameters, you may run into race condition as the same variable may be replaced with the second call before the first call completes.
I believe the parameter should pass down the call stack rather than setting a shared instance to be read later on by the GetQueryByWiqlAsync function call.
Same for the WorkItemQuery variable.
Co-authored-by: Vincent Biret <vibiret@microsoft.com>
….com/microsoftgraph/microsoft-graph-devx-api into task/switch-knowissues-organisations
|
SonarCloud Quality Gate failed.
|
Overview
Fixes #1608
Demo
Optional. Screenshots,
curlexamples, etc.Notes
Optional. Ancillary topics, caveats, alternative strategies that didn't work out, anything else.
Testing Instructions