Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLI] Snippet generation fix for overloaded bound functions that accept date parameter #1635

Merged
merged 9 commits into from
Jun 27, 2023
Merged

[CLI] Snippet generation fix for overloaded bound functions that accept date parameter #1635

merged 9 commits into from
Jun 27, 2023

Conversation

timayabi2020
Copy link
Contributor

Overview

Fixes #1621

Testing Instructions

  • Checkout branch associated with this PR
  • Run it locally and formulate the request as per the screenshot below showing the request and expected output.
image

@timayabi2020 timayabi2020 requested a review from a team as a code owner June 27, 2023 08:38
@timayabi2020 timayabi2020 linked an issue Jun 27, 2023 that may be closed by this pull request
[Cli] Wrong snippets generated for http snippets with overloaded bound functions that accept date parameter. #1621
Closed
timayabi2020 and others added 2 commits June 27, 2023 12:59
@timayabi2020 @andrueastman
Update CodeSnippetsReflection.OpenAPI/LanguageGenerators/GraphCliGene…
8952af1 
…rator.cs

Co-authored-by: Eastman <andrueastman@users.noreply.github.com>
@timayabi2020
Added regex to cover edge cases which are not only tied to 'period' p…
e45ea20 
…arameter in a loaded function
timayabi2020 and others added 3 commits June 27, 2023 15:50
@timayabi2020 @baywet
Update CodeSnippetsReflection.OpenAPI/LanguageGenerators/GraphCliGene…
7af2309 
…rator.cs

Co-authored-by: Vincent Biret <vibiret@microsoft.com>
@timayabi2020
Added unit test to test for function parameters with and without sing…
078a412 
…le or double quotes
@timayabi2020
Merge branch '1621-cli-wrong-snippets-generated-for-http-snippets-wit…
a80a2f2 
…h-overloaded-bound-functions-that-accept-date-parameter' of https://github.com/microsoftgraph/microsoft-graph-devx-api into 1621-cli-wrong-snippets-generated-for-http-snippets-with-overloaded-bound-functions-that-accept-date-parameter
baywet
baywet requested changes Jun 27, 2023
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, a few items still remain

@sonarcloud
Copy link

sonarcloud bot commented Jun 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

89.7% 89.7% Coverage
0.0% 0.0% Duplication

@timayabi2020 timayabi2020 merged commit f206299 into dev Jun 27, 2023
9 checks passed
@timayabi2020 timayabi2020 deleted the 1621-cli-wrong-snippets-generated-for-http-snippets-with-overloaded-bound-functions-that-accept-date-parameter branch June 27, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrueastman andrueastman andrueastman left review comments

@baywet baywet baywet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Cli] Wrong snippets generated for http snippets with overloaded bound functions that accept date parameter.
3 participants
@timayabi2020 @andrueastman @baywet