Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLI] Fixes query option params with url encoded values. #1647

Merged
merged 4 commits into from
Jun 29, 2023
Merged

[CLI] Fixes query option params with url encoded values. #1647

merged 4 commits into from
Jun 29, 2023

Conversation

timayabi2020
Copy link
Contributor

Overview

Fixes #1625

Demo

Testing Instructions

  • Checkout branch associated with this PR
  • Run it locally and formulate the request as per the screenshot below showing the request and expected output.
image
  • Run the cli snippet
image

@timayabi2020 timayabi2020 requested a review from a team as a code owner June 29, 2023 06:53
@timayabi2020 timayabi2020 linked an issue Jun 29, 2023 that may be closed by this pull request
[CLI] Inexecutable snippets generated for http snippets with url encoded values for system query options parameters. #1625
Closed
@timayabi2020 timayabi2020 changed the title Fixes query option params with url encoded values. [CLI] Fixes query option params with url encoded values. Jun 29, 2023
@timayabi2020 @andrueastman
Update CodeSnippetsReflection.OpenAPI/LanguageGenerators/GraphCliGene…
60ef381 
…rator.cs

Co-authored-by: Eastman <andrueastman@users.noreply.github.com>
@sonarcloud
Copy link

sonarcloud bot commented Jun 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@timayabi2020 timayabi2020 merged commit bcc813f into dev Jun 29, 2023
9 checks passed
@timayabi2020 timayabi2020 deleted the 1625-cli-inexecutable-snippets-generated-for-http-snippets-with-url-encoded-values-for-system-query-options-parameters branch June 29, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrueastman andrueastman andrueastman approved these changes

@millicentachieng millicentachieng millicentachieng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@timayabi2020 @andrueastman @millicentachieng