Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update go var name #1669

Merged
merged 2 commits into from
Jul 19, 2023
Merged

Update go var name #1669

merged 2 commits into from
Jul 19, 2023

Conversation

rkodev
Copy link
Contributor

@rkodev rkodev commented Jul 19, 2023 •
edited

Overview

Fixes #1114

Update go snippet result variable name to be the name of the resulting object before defaulting to the generic term result

Demo

current

result, err := graphClient.Groups().Post(context.Background(), requestBody, nil)

update version

groups, err := graphClient.Groups().Post(context.Background(), requestBody, nil)

Optional. Screenshots, curl examples, etc.

Notes

Closes #1115

Testing Instructions

  • Updated unit test

@rkodev rkodev requested a review from a team as a code owner July 19, 2023 08:18
@sonarcloud
Copy link

sonarcloud bot commented Jul 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

78.6% 78.6% Coverage
0.0% 0.0% Duplication

andrueastman
andrueastman approved these changes Jul 19, 2023
View reviewed changes
Copy link
Member

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @rkodev

Any chance you can create issues for the for the other openApi based languages and assign to the respective language owners?

@rkodev rkodev merged commit af33a04 into dev Jul 19, 2023
9 checks passed
@rkodev rkodev deleted the fix/update-go-var-names branch July 19, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrueastman andrueastman andrueastman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@rkodev @andrueastman