Bugfix/python snippets #1718
Merged
Bugfix/python snippets #1718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
CodeSnippetsReflection.OpenAPI/LanguageGenerators/PythonGenerator.cs
Outdated
Show resolved
Hide resolved
CodeSnippetsReflection.OpenAPI/LanguageGenerators/PythonGenerator.cs
Outdated
Show resolved
Hide resolved
CodeSnippetsReflection.OpenAPI/LanguageGenerators/PythonGenerator.cs
Outdated
Show resolved
Hide resolved
CodeSnippetsReflection.OpenAPI/LanguageGenerators/PythonGenerator.cs
Outdated
Show resolved
Hide resolved
| var snippetModel = new SnippetModel(requestPayload, ServiceRootUrl, await GetV1SnippetMetadata()); | ||
| var result = _generator.GenerateCodeSnippet(snippetModel); | ||
| Assert.Contains("request_body = Message(", result); | ||
| Assert.Contains("received_date_time = \"2021-08-30T20:00:00:00Z\"", result); |
There was a problem hiding this comment.
Should this be translated to an equivalent python DateTime object? Or are they represented as strings?
There was a problem hiding this comment.
The default datetime package doesn't cover all the datetime formats well, so we leverage a third party package dateutil for parsing during serialization/deserialization. If you pass a native datetime object, or a string both will work well.
…tor.cs Co-authored-by: Eastman <andrueastman@users.noreply.github.com>
…tor.cs Co-authored-by: Eastman <andrueastman@users.noreply.github.com>
|
Kudos, SonarCloud Quality Gate passed! |
andrueastman
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Resolves bugs in Python Snippets
Fixes: microsoftgraph/microsoft-graph-explorer-v4#2738
Demo
Optional. Screenshots,
curlexamples, etc.Notes
Optional. Ancillary topics, caveats, alternative strategies that didn't work out, anything else.
Testing Instructions