Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle regex creation errors #1731

Merged
merged 3 commits into from
Aug 23, 2023

Conversation

millicentachieng
Copy link
Contributor

@millicentachieng millicentachieng commented Aug 23, 2023

Overview

Fixes #1633

If template with no closing bracket is encountered, e.g. in /employeeexperience/learningproviders/{id}/learningcourseactivities(extern, an exception is thrown.

This PR handles the exception.

@millicentachieng millicentachieng force-pushed the fix/handle-url-template-matching-errors branch from 819d837 to 1499704 Compare August 23, 2023 15:47
@millicentachieng millicentachieng marked this pull request as ready for review August 23, 2023 15:49
@millicentachieng millicentachieng requested a review from a team as a code owner August 23, 2023 15:49
@millicentachieng millicentachieng enabled auto-merge (squash) August 23, 2023 15:50
@sonarcloud
Copy link

sonarcloud bot commented Aug 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

60.0% 60.0% Coverage
0.0% 0.0% Duplication

@millicentachieng millicentachieng merged commit 2e74ed4 into dev Aug 23, 2023
9 checks passed
@millicentachieng millicentachieng deleted the fix/handle-url-template-matching-errors branch August 23, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrap URL template matching within try catch block to gracefully handle errors in permissions file
2 participants