Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rsh/snippet generation java kiota #1748

Merged
merged 13 commits into from
Sep 22, 2023
Merged

Conversation

ramsessanchez
Copy link
Contributor

Fixes #1026
Adds snippet generation for the Kiota based Java-SDK using OpenApi

@ramsessanchez ramsessanchez requested a review from a team as a code owner September 6, 2023 22:20
@andrueastman
Copy link
Member

andrueastman commented Sep 7, 2023

Thanks for this @ramsessanchez. This looks great. Any chance you can checkout the sonarcloud warnings as well?

Sample run at https://dev.azure.com/microsoftgraph/Graph%20Developer%20Experiences/_build/results?buildId=124526&view=results is timing out as current branch is missing changes from #1719. A rebase/merge from dev is needed too.

Snippet generation for the Kiota based Java-Sdk (v6)
@ramsessanchez
Copy link
Contributor Author

There is one remaining code smell regarding the use of Last(), the smell suggests that using count-1 would be more efficient, however split returns an array so the smell actually is not helpful.

Code smells / styling
@ramsessanchez
Copy link
Contributor Author

@andrueastman I believe that we need to add the namespace change to dotNet snippet generation as well. While we can still use .me() the reference to the namespace .me was removed when we removed it during generation thus making some snippets uncompilable.

andrueastman
andrueastman previously approved these changes Sep 11, 2023
Copy link
Member

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrueastman I believe that we need to add the namespace change to dotNet snippet generation as well. While we can still use .me() the reference to the namespace .me was removed when we removed it during generation thus making some snippets uncompilable.

Thanks for pointing this out @ramsessanchez, I've updated the issue description at microsoftgraph/msgraph-sdk-dotnet#1874 to capture this when this is implemented in the next breaking change for dotnet

andrueastman
andrueastman previously approved these changes Sep 20, 2023
@ramsessanchez
Copy link
Contributor Author

Ready to merge, will continue fixes to snippet generation on later PR's

…r.cs

Co-authored-by: Mustafa Zengin <muzengin@microsoft.com>
@sonarcloud
Copy link

sonarcloud bot commented Sep 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

89.5% 89.5% Coverage
0.0% 0.0% Duplication

@ramsessanchez ramsessanchez merged commit 96c7cd6 into dev Sep 22, 2023
9 checks passed
@ramsessanchez ramsessanchez deleted the rsh/snippetGeneration_java_kiota branch September 22, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants