Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rectifies Bad Formatting in PowerShell snippets with If-Match request header #1769

Merged
merged 9 commits into from
Oct 11, 2023
Merged

Rectifies Bad Formatting in PowerShell snippets with If-Match request header #1769

merged 9 commits into from
Oct 11, 2023

Conversation

timayabi2020
Copy link
Contributor

@timayabi2020 timayabi2020 commented Oct 9, 2023 •
edited by microsoft-github-policy-service bot

Overview

Fixes #1522
Brief description of what this PR does, and why it is needed.

Demo

Current snippet and execution result
image

image

Expected snippet and execution result
image

image

Microsoft Reviewers: Open in CodeFlow

@timayabi2020 timayabi2020 requested a review from a team as a code owner October 9, 2023 11:31
@timayabi2020 timayabi2020 linked an issue Oct 9, 2023 that may be closed by this pull request
[PowerShell Snippets] Bad formatting forIf-Match header values #1522
Closed
andrueastman
andrueastman reviewed Oct 11, 2023
View reviewed changes
Copy link
Member

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance we can add a test to capture this scenario?

@sonarcloud
Copy link

sonarcloud bot commented Oct 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@timayabi2020 timayabi2020 merged commit 308d68a into dev Oct 11, 2023
11 checks passed
@timayabi2020 timayabi2020 deleted the 1522-powershell-snippets-bad-formatting-forif-match-header-values branch October 11, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrueastman andrueastman andrueastman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[PowerShell Snippets] Bad formatting forIf-Match header values
2 participants
@timayabi2020 @andrueastman