Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Snippets for Java #1798

Merged
merged 17 commits into from
Nov 15, 2023
Merged

Conversation

ramsessanchez
Copy link
Contributor

@ramsessanchez ramsessanchez commented Oct 26, 2023

-Fixes missing schema information in additionalData types.
-Replaces deltaResponse to deltaGetResponse for java snippets as that is what is generated in Kiota
-Removes the value identifier for java and generated .content() for snippets instead.
-Handle case where path parameter is an int and not a string, this is done in java and dotnet.

Microsoft Reviewers: Open in CodeFlow

@ramsessanchez ramsessanchez requested a review from a team as a code owner October 26, 2023 23:03
Copy link

sonarcloud bot commented Nov 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

97.4% 97.4% Coverage
0.0% 0.0% Duplication

@ramsessanchez ramsessanchez merged commit 896d640 into dev Nov 15, 2023
12 checks passed
@ramsessanchez ramsessanchez deleted the rsh/implementSnippetsForOpenTypes_Java branch November 15, 2023 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants