Add use import statements for PHP Snippets #2000

shemogumbe · 2024-03-19T13:02:39Z

Overview

Use statements added at the top of php snippets for model and request builder namespaces.

Demo

<?php
use Microsoft\Graph\Graph;
use Microsoft\Graph\Generated\Users\Item\Authentication\Operations\Item;


$graphServiceClient = new GraphServiceClient($tokenRequestContext, $scopes);

$requestConfiguration = new LongRunningOperationItemRequestBuilderGetRequestConfiguration();
$queryParameters = LongRunningOperationItemRequestBuilderGetRequestConfiguration::createQueryParameters();
$queryParameters->aadgdc = "AM4P";
$queryParameters->aadgsu = "ssprprod-a";
$requestConfiguration->queryParameters = $queryParameters;


$result = $graphServiceClient->users()->byUserId('user-id')->authentication()->operations()->byLongRunningOperationId('longRunningOperation-id')->get($requestConfiguration)->wait();

Testing Instructions

Check this branch https://github.com/microsoftgraph/microsoft-graph-docs/blob/preview-snippet-generation/140119/includes/snippets/php/v1/delta-query-groups-initial-request-php-snippets.md

CodeSnippetsReflection.OpenAPI/LanguageGenerators/PhpGenerator.cs

sonarcloud · 2024-03-25T13:51:38Z

Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
88.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Bump apidoctor from 1708be5 to 1916d8c (#2004) Add use import statements for PHP Snippets (#2000) Bump Microsoft.OpenApi.OData from 1.6.0 to 1.6.1 (#2007) Bump Microsoft.VisualStudio.Azure.Containers.Tools.Targets (#2008) Bump MSTest.TestFramework from 3.2.2 to 3.3.0 (#2009) Bump MSTest.TestFramework from 3.3.0 to 3.3.1 (#2011) Bump Microsoft.VisualStudio.Azure.Containers.Tools.Targets (#2010) Chore: change drop location (#2012)

* Merge dev to master (#2013) Bump apidoctor from 1708be5 to 1916d8c (#2004) Add use import statements for PHP Snippets (#2000) Bump Microsoft.OpenApi.OData from 1.6.0 to 1.6.1 (#2007) Bump Microsoft.VisualStudio.Azure.Containers.Tools.Targets (#2008) Bump MSTest.TestFramework from 3.2.2 to 3.3.0 (#2009) Bump MSTest.TestFramework from 3.3.0 to 3.3.1 (#2011) Bump Microsoft.VisualStudio.Azure.Containers.Tools.Targets (#2010) Chore: change drop location (#2012) * update submodules * update submodules --------- Co-authored-by: Millicent Achieng <achieng.milli@gmail.com> Co-authored-by: Charles Wahome <thewahome.cw@gmail.com>

* Merge dev to master (#2013) Bump apidoctor from 1708be5 to 1916d8c (#2004) Add use import statements for PHP Snippets (#2000) Bump Microsoft.OpenApi.OData from 1.6.0 to 1.6.1 (#2007) Bump Microsoft.VisualStudio.Azure.Containers.Tools.Targets (#2008) Bump MSTest.TestFramework from 3.2.2 to 3.3.0 (#2009) Bump MSTest.TestFramework from 3.3.0 to 3.3.1 (#2011) Bump Microsoft.VisualStudio.Azure.Containers.Tools.Targets (#2010) Chore: change drop location (#2012) * Remove built request configiguation name * Update unit tests for updated request configuration name * Update imports to inlcude base request configuration * update tests --------- Co-authored-by: Millicent Achieng <achieng.milli@gmail.com> Co-authored-by: Charles Wahome <thewahome.cw@gmail.com>

* update request configuration class (#2034) * Merge dev to master (#2013) Bump apidoctor from 1708be5 to 1916d8c (#2004) Add use import statements for PHP Snippets (#2000) Bump Microsoft.OpenApi.OData from 1.6.0 to 1.6.1 (#2007) Bump Microsoft.VisualStudio.Azure.Containers.Tools.Targets (#2008) Bump MSTest.TestFramework from 3.2.2 to 3.3.0 (#2009) Bump MSTest.TestFramework from 3.3.0 to 3.3.1 (#2011) Bump Microsoft.VisualStudio.Azure.Containers.Tools.Targets (#2010) Chore: change drop location (#2012) * Remove built request configiguation name * Update unit tests for updated request configuration name * Update imports to inlcude base request configuration * update tests --------- Co-authored-by: Millicent Achieng <achieng.milli@gmail.com> Co-authored-by: Charles Wahome <thewahome.cw@gmail.com> * Bump Microsoft.AspNetCore.Authorization from 8.0.4 to 8.0.5 (#2049) Bumps [Microsoft.AspNetCore.Authorization](https://github.com/dotnet/aspnetcore) from 8.0.4 to 8.0.5. - [Release notes](https://github.com/dotnet/aspnetcore/releases) - [Changelog](https://github.com/dotnet/aspnetcore/blob/main/docs/ReleasePlanning.md) - [Commits](dotnet/aspnetcore@v8.0.4...v8.0.5) --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.Authorization dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump Microsoft.AspNetCore.Authentication.JwtBearer from 8.0.4 to 8.0.5 (#2048) Bumps [Microsoft.AspNetCore.Authentication.JwtBearer](https://github.com/dotnet/aspnetcore) from 8.0.4 to 8.0.5. - [Release notes](https://github.com/dotnet/aspnetcore/releases) - [Changelog](https://github.com/dotnet/aspnetcore/blob/main/docs/ReleasePlanning.md) - [Commits](dotnet/aspnetcore@v8.0.4...v8.0.5) --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.Authentication.JwtBearer dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix model import paths + Add support for enum imports (#2047) * Initial work on fixing paths. * Remove unused test. * Add imports for DateOnly, TimeOnly and Enums. * Fix issue with spelling. * Do slight refactor to improve style. * Fix more issues with the snippets. * Take care of corner cases. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Shem Ogumbe <shemnashon@gmail.com> Co-authored-by: Millicent Achieng <achieng.milli@gmail.com> Co-authored-by: Charles Wahome <thewahome.cw@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Merge dev to master (#2013) Bump apidoctor from 1708be5 to 1916d8c (#2004) Add use import statements for PHP Snippets (#2000) Bump Microsoft.OpenApi.OData from 1.6.0 to 1.6.1 (#2007) Bump Microsoft.VisualStudio.Azure.Containers.Tools.Targets (#2008) Bump MSTest.TestFramework from 3.2.2 to 3.3.0 (#2009) Bump MSTest.TestFramework from 3.3.0 to 3.3.1 (#2011) Bump Microsoft.VisualStudio.Azure.Containers.Tools.Targets (#2010) Chore: change drop location (#2012) * update submodules * update submodules * Latest dev changes. (#2053) * update request configuration class (#2034) * Merge dev to master (#2013) Bump apidoctor from 1708be5 to 1916d8c (#2004) Add use import statements for PHP Snippets (#2000) Bump Microsoft.OpenApi.OData from 1.6.0 to 1.6.1 (#2007) Bump Microsoft.VisualStudio.Azure.Containers.Tools.Targets (#2008) Bump MSTest.TestFramework from 3.2.2 to 3.3.0 (#2009) Bump MSTest.TestFramework from 3.3.0 to 3.3.1 (#2011) Bump Microsoft.VisualStudio.Azure.Containers.Tools.Targets (#2010) Chore: change drop location (#2012) * Remove built request configiguation name * Update unit tests for updated request configuration name * Update imports to inlcude base request configuration * update tests --------- Co-authored-by: Millicent Achieng <achieng.milli@gmail.com> Co-authored-by: Charles Wahome <thewahome.cw@gmail.com> * Bump Microsoft.AspNetCore.Authorization from 8.0.4 to 8.0.5 (#2049) Bumps [Microsoft.AspNetCore.Authorization](https://github.com/dotnet/aspnetcore) from 8.0.4 to 8.0.5. - [Release notes](https://github.com/dotnet/aspnetcore/releases) - [Changelog](https://github.com/dotnet/aspnetcore/blob/main/docs/ReleasePlanning.md) - [Commits](dotnet/aspnetcore@v8.0.4...v8.0.5) --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.Authorization dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump Microsoft.AspNetCore.Authentication.JwtBearer from 8.0.4 to 8.0.5 (#2048) Bumps [Microsoft.AspNetCore.Authentication.JwtBearer](https://github.com/dotnet/aspnetcore) from 8.0.4 to 8.0.5. - [Release notes](https://github.com/dotnet/aspnetcore/releases) - [Changelog](https://github.com/dotnet/aspnetcore/blob/main/docs/ReleasePlanning.md) - [Commits](dotnet/aspnetcore@v8.0.4...v8.0.5) --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.Authentication.JwtBearer dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix model import paths + Add support for enum imports (#2047) * Initial work on fixing paths. * Remove unused test. * Add imports for DateOnly, TimeOnly and Enums. * Fix issue with spelling. * Do slight refactor to improve style. * Fix more issues with the snippets. * Take care of corner cases. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Shem Ogumbe <shemnashon@gmail.com> Co-authored-by: Millicent Achieng <achieng.milli@gmail.com> Co-authored-by: Charles Wahome <thewahome.cw@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Millicent Achieng <achieng.milli@gmail.com> Co-authored-by: Charles Wahome <thewahome.cw@gmail.com> Co-authored-by: shemogumbe <shemogumbe@microsoft.com> Co-authored-by: Shem Ogumbe <shemnashon@gmail.com> Co-authored-by: Faith Kangai <fey101@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Merge dev to master (#2013) Bump apidoctor from 1708be5 to 1916d8c (#2004) Add use import statements for PHP Snippets (#2000) Bump Microsoft.OpenApi.OData from 1.6.0 to 1.6.1 (#2007) Bump Microsoft.VisualStudio.Azure.Containers.Tools.Targets (#2008) Bump MSTest.TestFramework from 3.2.2 to 3.3.0 (#2009) Bump MSTest.TestFramework from 3.3.0 to 3.3.1 (#2011) Bump Microsoft.VisualStudio.Azure.Containers.Tools.Targets (#2010) Chore: change drop location (#2012) * Remove built request configiguation name * Update unit tests for updated request configuration name * Update imports to inlcude base request configuration * update tests --------- Co-authored-by: Millicent Achieng <achieng.milli@gmail.com> Co-authored-by: Charles Wahome <thewahome.cw@gmail.com>

shemogumbe added 21 commits March 19, 2024 16:01

Draft php imports in snippets

c5ce95b

fix import paths for models and request builders php

1ce78f9

add imports after opening php tag

b6dd764

fix request builder namespace paths

4d85aa7

fix request builder namespace and path

c50eabf

do not transform imports parts to lowercase or snake case

67965a8

replace . with \\ in requestbuilder namespace path

ba80fb0

replace . with \\ in requestbuilder namespace path

aa52e79

remove double slashes on request builder path

61c1edd

fix replace dots with slashes on import paths

5f351b4

fix replace dots with slashes on import paths -change case

dc939fd

fix dot to slash replacement

2c3f0c7

fix dot to slash replacement

3cbb7a0

Update request builder path

52c0ec4

Update request builder path - change casing

96e365c

remove double slashes on request builder paths

c25fbbc

remove equest builder name- use namespace only for imports

b084377

remove model name - use model namespace without fqcn

aa10935

remove model name - use model namespace without fqcn

6eff992

unit tests for php use statements

e1979fc

add unit tests for use statements in php snippets

28e5bc1

shemogumbe marked this pull request as ready for review March 20, 2024 15:37

shemogumbe requested a review from a team as a code owner March 20, 2024 15:37

shemogumbe requested review from andrueastman, Ndiritu, SilasKenneth, samwelkanda and rkodev March 20, 2024 15:39

shemogumbe added 2 commits March 20, 2024 18:44

move tests to php generator test

ecbe529

fix code coverage

39737b6

andrueastman reviewed Mar 21, 2024

View reviewed changes

shemogumbe requested a review from SilasKenneth March 21, 2024 12:57

shemogumbe added 16 commits March 22, 2024 17:10

add request builder filename to import

5e28ebf

add model and request builder class name import

56d2526

fix tests include class names on imports

e1073f0

fix import class names

57a1345

improve code readability

2c50c33

fix indentation

9666b45

update classname in imports

105f874

fix casing for request builder name

8ae1bf0

fix casing for request builder name

a450747

Update tests to reflect request builde class names

6e2220b

remove duplicate unit tests

0fb9297

fix failing tests

3e9d947

fix failing tests

5c85dfc

Convert importsgenerator to static class

68b437c

Fix snippet import tests

92a6469

remove duplcate unit tests

fde5539

andrueastman approved these changes Mar 25, 2024

View reviewed changes

SilasKenneth approved these changes Mar 26, 2024

View reviewed changes

shemogumbe merged commit 94e5641 into dev Mar 26, 2024
11 checks passed

shemogumbe deleted the shem/php_snipet_imports branch March 26, 2024 19:34

thewahome mentioned this pull request Apr 8, 2024

Merge dev to master #2013

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add use import statements for PHP Snippets #2000

Add use import statements for PHP Snippets #2000

shemogumbe commented Mar 19, 2024 •

edited

Loading

sonarcloud bot commented Mar 25, 2024

Add use import statements for PHP Snippets #2000

Add use import statements for PHP Snippets #2000

Conversation

shemogumbe commented Mar 19, 2024 • edited Loading

Overview

Demo

Testing Instructions

sonarcloud bot commented Mar 25, 2024

Quality Gate passed

shemogumbe commented Mar 19, 2024 •

edited

Loading