Add version select #205
Merged
Add version select #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bettirosengugi I tried to fetch a query on v2.0 url but I got a 404 not sure we have support for v2.0 cc@cwahome |
It's because the versions available are v1.0 and beta... |
ghost
changed the base branch from
|
@Kachulio1 , I am merging this in to fix/add-version-select instead of dev so as to build on the changes you made with some improvements. cc @bettirosengugi |
ghost
mentioned this pull request
Merged
ghost
pushed a commit
that referenced
this pull request
Oct 16, 2019
* Add version select (#205) * add urlVersions type * add version handler function * add version dropdown * change the version to lowerCase * change the url version * moves version selection to redux * moves state properties from query runner to input * changes to appropriate query version when query clicked * adds tests for SELECT_VERSION_SUCCESS * adds displayRequestComponent toggle for try it * renames selectQueryVersion to setQueryVersion * describes options variable as urlVersion | method * creates and utilises a function to parse urls to sample urls * sets the selected version when editor changed * increases control sizes to reduce ellipsis use * moves selectedVersion to sampleQuery property
asith-w
pushed a commit
to asith-w/microsoft-graph-explorer-v2
that referenced
this pull request
Nov 7, 2019
* Add version select (microsoftgraph#205) * add urlVersions type * add version handler function * add version dropdown * change the version to lowerCase * change the url version * moves version selection to redux * moves state properties from query runner to input * changes to appropriate query version when query clicked * adds tests for SELECT_VERSION_SUCCESS * adds displayRequestComponent toggle for try it * renames selectQueryVersion to setQueryVersion * describes options variable as urlVersion | method * creates and utilises a function to parse urls to sample urls * sets the selected version when editor changed * increases control sizes to reduce ellipsis use * moves selectedVersion to sampleQuery property
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
enable URL version select
FIxes #200
Demo