Fix: add version select #215
Conversation
* add urlVersions type * add version handler function * add version dropdown * change the version to lowerCase * change the url version
ghost
requested review from
ghost
changed the title
|
@bettirosengugi a while back there was the issue reported by @jthake-msft where for certain screen sizes the http methods were shown to have an ellipsis ie |
@jobala why don't we have the same issue in classic yet it has the three tabs (Request Options, Version and query tabs) ? May be investigate? |
This is correct to give an example if the version selected is V1, the url for /me should be https://graph.microsoft.com/v1.0/me and when you change the version to beta the url should change to https://graph.microsoft.com/beta/me and the selected version should show on the drop down tab. |
There's also a third type of url version |
That's a good question. AFAIK classic uses MWF and |
There was a problem hiding this comment.
const requestUrl = query.url.replace(GRAPH_URL, '');
const queryVersion = requestUrl.substring(1, 5);
The above code snippet has been duplicated in various places. It will be wise to abstract it into a function.
Why do we need a reducer and an action-creator for the version selector?
Now changes when you change the url in the editor. Good catch @jobala
I have improved the column definitions to reduce the need for the ellipsis in smaller screen sizes
I have added a utility function for reuse for this.
The version is used and changed at different points of the application. |
* Add version select (microsoftgraph#205) * add urlVersions type * add version handler function * add version dropdown * change the version to lowerCase * change the url version * moves version selection to redux * moves state properties from query runner to input * changes to appropriate query version when query clicked * adds tests for SELECT_VERSION_SUCCESS * adds displayRequestComponent toggle for try it * renames selectQueryVersion to setQueryVersion * describes options variable as urlVersion | method * creates and utilises a function to parse urls to sample urls * sets the selected version when editor changed * increases control sizes to reduce ellipsis use * moves selectedVersion to sampleQuery property
Overview
Adds a version selector option
The version selection changes automatically when you select queries from the sidebar.
Improves #205
Fixes #200
Demo
Testing Instructions