Fix: duplicate aria labels (#752)

* Update aria-label * localize aria labels
microsoftgraph · Nov 9, 2020 · 1a70245 · 1a70245
1 parent 51cf90f
commit 1a70245
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/src/app/views/query-runner/QueryInput.tsx b/src/app/views/query-runner/QueryInput.tsx
@@ -6,6 +6,7 @@ import { connect } from 'react-redux';
 import { Mode } from '../../../types/enums';
 import { IQueryInputProps } from '../../../types/query-runner';
 import { getStyleFor } from '../../utils/badge-color';
+import { translateMessage } from '../../utils/translate-messages';
 import SubmitButton from '../common/submit-button/SubmitButton';
 import { queryRunnerStyles } from './QueryRunner.styles';
 
@@ -72,7 +73,7 @@ export class QueryInput extends Component<IQueryInputProps, any> {
       <div className='row'>
         <div className='col-xs-12 col-lg-2'>
           <Dropdown
-            ariaLabel='Query sample option'
+            ariaLabel={translateMessage('HTTP request method option')}
             role='listbox'
             selectedKey={selectedVerb}
             options={httpMethodsToDisplay}
@@ -82,7 +83,7 @@ export class QueryInput extends Component<IQueryInputProps, any> {
         </div>
         <div className='col-xs-12 col-lg-2'>
           <Dropdown
-            ariaLabel='Query sample option'
+            ariaLabel={translateMessage('Microsoft Graph API Version option')}
             role='listbox'
             selectedKey={selectedVersion || 'v1.0'}
             options={urlVersions}
@@ -91,7 +92,7 @@ export class QueryInput extends Component<IQueryInputProps, any> {
         </div>
         <div className='col-xs-12 col-lg-6'>
           <TextField
-            ariaLabel='Query Sample Input'
+            ariaLabel={translateMessage('Query Sample Input')}
             role='textbox'
             placeholder={messages['Query Sample']}
             onChange={(event, value) => handleOnUrlChange(value)}

diff --git a/src/messages/GE.json b/src/messages/GE.json
@@ -319,5 +319,8 @@
   "Administrator permission": "Admin of the tenant needs to authorize first before you can consent to this permission",
   "Adaptive Cards designer": "Adaptive Cards designer.",
   "Click Run Query button above to fetch Adaptive Card": "Click Run Query button above to fetch Adaptive Card.",
-  "Your history includes queries made in the last 30 days": "Your history includes queries made in the last 30 days"
+  "Your history includes queries made in the last 30 days": "Your history includes queries made in the last 30 days",
+  "HTTP request method option": "HTTP request method option",
+  "Microsoft Graph API Version option": "Microsoft Graph API Version option",
+  "Query Sample Input": "Query sample input"
 }