Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: sample query sample body #775

Merged
merged 8 commits into from
Dec 4, 2020
Merged

Conversation

thewahome
Copy link
Collaborator

Overview

Noticed that the sample body was not displayed as HTML in the editor.
Enhanced code to get and display data in the DetailList to a reusable function

Notes

Refactoring has been done to generate groups from a list into a reusable function so that the logic is handled in one place.

Testing Instructions

  • Log in to graph explorer
  • search for "create page" in the samples
  • Click the sample
  • Notice the HTML is displayed
  • Include test case, and expected output

@thewahome thewahome added the type:infrastructure Core back-end work which includes quality work, code refactor, tests etc label Nov 30, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2020

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-775.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2020

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-775.centralus.azurestaticapps.net

Copy link
Contributor

@millicentachieng millicentachieng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an error in the editor: Expected a JSON object, array or literal. Is there a way to have this can be handled?

Also, are we expecting any other formats other than JSON and HTML?

@millicentachieng millicentachieng dismissed their stale review December 4, 2020 14:15

I've added comments

@millicentachieng
Copy link
Contributor

image

@thewahome
Copy link
Collaborator Author

@millicentachieng this is expected . We do not specify the type of content to display in the request body at the moment, so we default to a string. The editor is able to format it properly. Which works.

@thewahome thewahome merged commit b64a110 into dev Dec 4, 2020
ElinorW added a commit that referenced this pull request Dec 9, 2020
* Telemetry: Normalize Query URL and Redact PII (#734)

* Feature: autocomplete (#480)

* Localized GE.jsons HB (#776)

* Prevent remote dependency and trace information telemetry types from being captured (#770)

* Fix: sample query sample body (#775)

* Fix: stop display of options when fetching suggestions (#778)

* add aria-label (#780)

* chore(release): 4.1.12
@millicentachieng millicentachieng deleted the fix/sample-query-sample-body branch January 28, 2021 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:infrastructure Core back-end work which includes quality work, code refactor, tests etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants