Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent remote dependency and trace information telemetry types from being captured #770

Merged
merged 6 commits into from
Dec 3, 2020

Conversation

millicentachieng
Copy link
Contributor

@millicentachieng millicentachieng commented Nov 24, 2020

Exclude remote dependency and trace information telemetry data from being captured.

Telemetry types being captured:

  • Custom events
  • Custom metrics
  • Exceptions
  • Page views

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-770.centralus.azurestaticapps.net

@thewahome
Copy link
Collaborator

@millicentachieng how do we test this?

@millicentachieng
Copy link
Contributor Author

@millicentachieng how do we test this?

By logging into the Azure Portal and checking if the excepted telemetry types are being captured.

@millicentachieng
Copy link
Contributor Author

@irvinesunday, @thewahome please review

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-770.centralus.azurestaticapps.net

@thewahome
Copy link
Collaborator

@millicentachieng what type of data should I look out for? I am not quite sure what to expect

@millicentachieng
Copy link
Contributor Author

@millicentachieng what type of data should I look out for? I am not quite sure what to expect

@thewahome I've updated the description of the PR to include the list

@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2020

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-770.centralus.azurestaticapps.net

private includeSpecifiedTelemetryTypes(envelope: ITelemetryItem) {
const baseType = envelope.baseType || '';
const typesToInclude = ['EventData', 'MetricData', 'ExceptionData', 'PageviewData'];
if (!typesToInclude.includes(baseType)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: change the condition to make it slightly more readable.

if (typesToInclude.includes(baseType)) {
   return true;
}
return false;

@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2020

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-770.centralus.azurestaticapps.net

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2020

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-770.centralus.azurestaticapps.net

@millicentachieng millicentachieng merged commit 3cb2781 into dev Dec 3, 2020
@millicentachieng millicentachieng deleted the feature/disable-unnecessary-telemetry-items branch December 3, 2020 16:49
ElinorW added a commit that referenced this pull request Dec 9, 2020
* Telemetry: Normalize Query URL and Redact PII (#734)

* Feature: autocomplete (#480)

* Localized GE.jsons HB (#776)

* Prevent remote dependency and trace information telemetry types from being captured (#770)

* Fix: sample query sample body (#775)

* Fix: stop display of options when fetching suggestions (#778)

* add aria-label (#780)

* chore(release): 4.1.12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants