-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent remote dependency and trace information telemetry types from being captured #770
Prevent remote dependency and trace information telemetry types from being captured #770
Conversation
Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-770.centralus.azurestaticapps.net |
@millicentachieng how do we test this? |
By logging into the Azure Portal and checking if the excepted telemetry types are being captured. |
@irvinesunday, @thewahome please review |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-770.centralus.azurestaticapps.net |
@millicentachieng what type of data should I look out for? I am not quite sure what to expect |
@thewahome I've updated the description of the PR to include the list |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-770.centralus.azurestaticapps.net |
src/telemetry/telemetry.ts
Outdated
private includeSpecifiedTelemetryTypes(envelope: ITelemetryItem) { | ||
const baseType = envelope.baseType || ''; | ||
const typesToInclude = ['EventData', 'MetricData', 'ExceptionData', 'PageviewData']; | ||
if (!typesToInclude.includes(baseType)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: change the condition to make it slightly more readable.
if (typesToInclude.includes(baseType)) {
return true;
}
return false;
Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-770.centralus.azurestaticapps.net |
1 similar comment
Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-770.centralus.azurestaticapps.net |
* Telemetry: Normalize Query URL and Redact PII (#734) * Feature: autocomplete (#480) * Localized GE.jsons HB (#776) * Prevent remote dependency and trace information telemetry types from being captured (#770) * Fix: sample query sample body (#775) * Fix: stop display of options when fetching suggestions (#778) * add aria-label (#780) * chore(release): 4.1.12
Exclude remote dependency and trace information telemetry data from being captured.
Telemetry types being captured: