Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: stop display of options when fetching suggestions #778

Merged
merged 2 commits into from
Dec 7, 2020

Conversation

thewahome
Copy link
Collaborator

Overview

Noticed that as the request for autocomplete options is running, the results of the previous run are displayed.
If the call is running, only the spinner should show until the content is found or not.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2020

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-778.centralus.azurestaticapps.net

Copy link
Collaborator

@ElinorW ElinorW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@thewahome thewahome merged commit 4aad40d into dev Dec 7, 2020
ElinorW added a commit that referenced this pull request Dec 9, 2020
* Telemetry: Normalize Query URL and Redact PII (#734)

* Feature: autocomplete (#480)

* Localized GE.jsons HB (#776)

* Prevent remote dependency and trace information telemetry types from being captured (#770)

* Fix: sample query sample body (#775)

* Fix: stop display of options when fetching suggestions (#778)

* add aria-label (#780)

* chore(release): 4.1.12
@thewahome thewahome deleted the fix/stop-display-of-options-while-fetching branch February 17, 2021 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants