Fix: prevent running empty requests #965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-965.centralus.azurestaticapps.net |
nikithauc
approved these changes
May 26, 2021
ElinorW
added a commit
that referenced
this pull request
Nov 11, 2021
* add office feedback package * add feedback option * set up feedback functionality * display custom survey * add multi-feedback method * remove unused package * add feedback pivot item * configure feedback initialization settings * Add feedback message * added styling * refactor code * change string * Add custom survey * add initialization settings * add styling * add aria labels and remove unused code * remove unused code * get and set locale * update styling * Add surveyActivated option * add localization * add more localization * leave email field empty * remove onDismiss log activity * add more localization * format code * adding nprmc configuration script * add token refresh script * modify 'npm install' to task * add custom registry * add authentication task * add authentication * disable 'npm Authenticate' task * add refresh token script to pipeline * move tasks up the jobs * install eslint globally * install eslint-cli globally * disabling npm lint * separate commands * remove package authentication * disable authentication package installation * change always-auth * enable authentication * add authentication * remove Authentication task * add token * add authentication script * install vsts package * separate tasks * Update azure-pipelines.yml for Azure Pipelines * remove space * remove package * Install office feedback package * Update azure-pipelines.yml for Azure Pipelines * add token * disable vsts script * Remove colon. * Remove package-lock.json * Use manual token * Update * Scope registry * Update npm * Add eslint packages * Use legacy peer deps * Fix typo * fix accessibility error * remove legacy peer deps * add packages * use legacy peer deps * add packages * fix query runner error * remove package-lock.json * add npm install * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Fix: Update GitHub workflow (#962) * edit github workflow * add trigger on feature branches * break down npm install step * install office package * add package registry * added package authentication * rearrange steps * add package authentication * Fix indenting * add authentication * fix indentation * fix typo * Setup Node step again * remove steps * Setting package registry * Add legacy peer deps * list configs * Delete .npmrc file * Display location * add bash * set again * remove config * remove npmrc * move to dev dependency * add .npmrc file * rearrange steps * set github actions to creat .npmrc config * remove npmrc * add package registry * add scoped package * remove registry tag * set officebrowserfeedbacknpm to specific package version * set registry when installing from office * install officebrowserfeedbacknpm globally * upgrade to static-...-deploy v1 * add custom build command * reset app_location * add default file to build output folder * remove custom build * add augloop dependency * move augloop up * set always-auth=false * move build and install steps out of builddeploy * revert npmrc config * consolidate config changes * add scopes * change registry order * Set npm package registry * trigger on dev only Co-authored-by: Charles Wahome <thewahome.cw@gmail.com> * update init options * Fix: Concept try-it button (#966) * code refactor * Move feedbackWrapper logic to FeedbackForm * add build * update localized strings * remove package-lock.json * Fix: prevent running empty requests (#965) * add check for whether the sample url is present * display error message when sample url is empty * Add privacy comment * add package-lock.json * update dependency * add tenantId * add loggableUserId * remove npm install * add package authentication * remove optional permission property * add token authentication * reorder steps * Reorder Pipeline steps. Add azure artifacts to npmrc. Resolve augloop dependency. * chore(release): 4.7.0 * auth to feed * add registry * authenticate * add augloop * reorder job two * add authentication on workflow * add preinstall step * remove caret * remove preinstall script * npm install from local folder * add compaign ID * fix typo * add preinstall * restore workflow * refactor code * add authentication check * update library * update package * add styling * Add nps feedback * add nps form functionality * remove commented code * add getAgeGroup function * return undefined profile type * refactor age group function * check authentication status * add ocps call function * correct typo * add token configuration * modify ocps action * remove unused import * add ocps reducer * fetch ocps token * enable feedback when a user is logged in * dispatch getPolicies action * remove authentication condition * update packages * refactor code and fix linting errors * Fix linting errors * remove pre-install step * add typings * add .npmrc file * add packages folder * add fluent ui * fix linting errors * update package name * update package-lock.json * localize strings * code cleanup * add campaing id to env * add feedbackEnabled check * Update src/app/views/query-runner/request/Request.tsx Co-authored-by: Charles Wahome <thewahome.cw@gmail.com> * refactor code * remove preventDefault function * add env variables * add localization * modify policy url * set request-body as default pivot item * fix pivot navigation * remove console statement * update settings Co-authored-by: Charles Wahome <thewahome.cw@gmail.com> Co-authored-by: jobala <japhethobalak@gmail.com> Co-authored-by: George <gendungu@microsoft.com> Co-authored-by: George <1641829+georgend@users.noreply.github.com>
ElinorW
added a commit
that referenced
this pull request
Nov 18, 2021
* HB of localized GE.jsons (#1094) * Capture telemetry for Graph Proxy API calls (#1098) * Capture GE mode for all telemetry items (#1105) * Update how we are sanitizing track trace to include more info (#1122) * Capture telemetry for graph toolkit example link (#1125) * chore: handover-translations (#1107) * Feature: input hints (#1104) * Enhancement: Make pivots headers responsive (#1121) * Chore: add linter workflow (#1132) * Fix: linting errors (#1133) * Fix: Request headers textfield bug (#1137) * Fix: Update packages (#1138) * Fix: makes query color in the text area black (#1152) * Fix: CORS workaround to enable downloading of content (#1032) * Fix: Accessibility error for 'button-name' (#1164) * Fix: move documentation links to the first column (#1158) * Fix: Add focus on button (#1153) * Fix: Create user when emailAddress is unavailable (#1165) * Chore: add dependabot configuration (#1188) * Fix: try it interaction (#1185) * Fix: failing nextlink call (#1184) * Fix: request and response height (#1201) * Fix: Remove hover functions on history tab (#1204) * Feature: Add feedback button and pop-up (#1183) * Fix: Update GitHub workflow (#962) * Fix: Concept try-it button (#966) * Fix: prevent running empty requests (#965) * Task: add description to documentation link (#1203) * Chore: translate to German (#1208) * validate index of selected query (#1210) * Translate to portuguese (#1212) * Chore: Handover translations (#1213) * Chore(deps): Bump @babel/eslint-parser from 7.12.13 to 7.16.3 (#1207) * Feature: adds go to the snippet tabs (#1189) * Chore: (Dependabot) Update packages (#1220) * Chore(deps): Bump jest-watch-typeahead from 0.2.1 to 0.5.0 (#1199) * Chore(deps): Bump @axe-core/webdriverjs from 4.2.2 to 4.3.1 (#1192) * Chore(deps-dev): Bump react-test-renderer from 16.8.3 to 16.13.0 (#1195) * Chore(deps): Bump eslint-plugin-flowtype from 2.50.1 to 2.50.3 (#1198) * Chore(deps): Bump re-resizable from 6.9.0 to 6.9.1 (#1197) * Chore(deps): Bump terser-webpack-plugin from 3.1.0 to 4.2.3 (#1196) * Chore(deps): Bump file-loader from 2.0.0 to 6.2.0 (#1194) * Chore(deps-dev): Bump @types/react from 16.8.3 to 17.0.35 (#1219) * Chore(deps): Bump react from 16.8.2 to 16.14.0 (#1193) * Fix: Linting errors in snippets (#1233) * Fix: Failure to load on Safari (Mac) (#1222) * chore(release): 4.14.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes #643
Demo
Notes
Optional. Ancillary topics, caveats, alternative strategies that didn't work out, anything else.
Testing Instructions