Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Add feedback button and pop-up #1183

Merged
merged 175 commits into from
Nov 11, 2021
Merged

Feature: Add feedback button and pop-up #1183

merged 175 commits into from
Nov 11, 2021

Conversation

ElinorW
Copy link
Collaborator

@ElinorW ElinorW commented Nov 2, 2021 •
edited
Loading

Overview

This PR:

  • Adds the feedback button
  • Adds the NPS feedback, that is triggered automatically based on user activity
  • Ensures we collect the Age Group value for MSA users (GDPR Compliance)
  • Ensures we collect the tenant policies specified for an enterprise user (GDPR compliance)

Fixes #1092, #1052

Demo

Feedback button
image

Feedback pop-up
image

Testing Instructions

Testing the feedback button

  • Navigate to the "Got Feedback" tab and select it.
  • Fill in the feedback form
  • Attempt the same using different accounts (i.e AAD and MSA)

Testing the NPS pop up

  • Load Graph Explorer and interact with the page for a minute (this is important, you must be active on the page for longer than a minute)
  • Navigate out of the page (e.g open a new tab)
  • Return to Graph Explorer and interact with a component
  • Observe the pop up appears requesting your feedback
  • Fill in the form and submit

##Notes

  1. The forms do not have a dark mode/high contrast mode setting
  2. User's signing in with their @microsoft account may receive a prompt requiring admin approval. A user can select 'Return to the application without granting consent'. Nothing get's affected.
    image

@ElinorW
add office feedback package
c3f0c3e
@ElinorW
add feedback option
0a9ebc5
@ElinorW
set up feedback functionality
73170f9
@ElinorW
display custom survey
4cdff80
@ElinorW
add multi-feedback method
64e0ced
@ElinorW
remove unused package
5831291
@ElinorW
add feedback pivot item
367613e
@ElinorW
configure feedback initialization settings
9ef08db
@ElinorW
Add feedback message
5da3a71
@ElinorW
added styling
429b6c6
@ElinorW
refactor code
c880488
@ElinorW
change string
30511ee
@ElinorW
Add custom survey
1cd508f
@ElinorW
add initialization settings
8ed8978
@ElinorW
add styling
95beb47
@ElinorW
add aria labels and remove unused code
1f4e4f6
@ElinorW
remove unused code
e7d1209
@ElinorW
get and set locale
0f15b2e
@ElinorW
update styling
08a37b1
@ElinorW
Add surveyActivated option
e784b1b
@ElinorW
add localization
9c8a201
@ElinorW
add more localization
eb4fd71
@ElinorW
Merge branch 'dev' into feature/in-app-feedback
d43aac0
@ElinorW
leave email field empty
bf4c93b
@ElinorW
remove onDismiss log activity
2268a61
@ElinorW
add more localization
561200b
@ElinorW
format code
e24d3ff
@ElinorW
adding nprmc configuration script
509833b
@ElinorW
add token refresh script
38a6b9b
@ElinorW
Merge branch 'feature/in-app-feedback' of https://github.com/microsof…
edc23c2 
…tgraph/microsoft-graph-explorer-v4 into feature/in-app-feedback
@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2021

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-1183.centralus.azurestaticapps.net

2 similar comments
@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2021

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-1183.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2021

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-1183.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-1183.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-1183.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-1183.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-1183.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-1183.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-1183.centralus.azurestaticapps.net

thewahome
thewahome approved these changes Nov 11, 2021
View reviewed changes
Copy link
Collaborator

@thewahome thewahome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FLGTM

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-1183.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-1183.centralus.azurestaticapps.net

@ElinorW ElinorW merged commit 1fbd7e0 into dev Nov 11, 2021
@thewahome thewahome deleted the feature/nps-feedback-2 branch November 15, 2021 15:00
ElinorW added a commit that referenced this pull request Nov 18, 2021
@ElinorW
Release: November 2021 (#1238)
edfb717 
* HB of localized GE.jsons (#1094)

* Capture telemetry for Graph Proxy API calls (#1098)

* Capture GE mode for all telemetry items (#1105)

* Update how we are sanitizing track trace to include more info (#1122)

* Capture telemetry for graph toolkit example link (#1125)

* chore: handover-translations (#1107)

* Feature: input hints (#1104)

* Enhancement: Make pivots headers responsive (#1121)

* Chore: add linter workflow (#1132)

* Fix: linting errors (#1133)

* Fix: Request headers textfield bug (#1137)

* Fix: Update packages (#1138)

* Fix: makes query color in the text area black (#1152)

* Fix: CORS workaround to enable downloading of content (#1032)

* Fix: Accessibility error for 'button-name' (#1164)

* Fix: move documentation links to the first column (#1158)

* Fix: Add focus on button (#1153)

* Fix: Create user when emailAddress is unavailable (#1165)

* Chore: add dependabot configuration (#1188)

* Fix: try it interaction (#1185)

* Fix: failing nextlink call (#1184)

* Fix: request and response height (#1201)

* Fix: Remove hover functions on history tab (#1204)

* Feature: Add feedback button and pop-up (#1183)

* Fix: Update GitHub workflow (#962)

* Fix: Concept try-it button (#966)

* Fix: prevent running empty requests (#965)

* Task: add description to documentation link (#1203)

* Chore: translate to German (#1208)

* validate index of selected query (#1210)

* Translate to portuguese (#1212)

* Chore: Handover translations (#1213)

* Chore(deps): Bump @babel/eslint-parser from 7.12.13 to 7.16.3 (#1207)

* Feature: adds go to the snippet tabs (#1189)

* Chore: (Dependabot) Update packages (#1220)

* Chore(deps): Bump jest-watch-typeahead from 0.2.1 to 0.5.0 (#1199)

* Chore(deps): Bump @axe-core/webdriverjs from 4.2.2 to 4.3.1 (#1192)

* Chore(deps-dev): Bump react-test-renderer from 16.8.3 to 16.13.0 (#1195)

* Chore(deps): Bump eslint-plugin-flowtype from 2.50.1 to 2.50.3 (#1198)

* Chore(deps): Bump re-resizable from 6.9.0 to 6.9.1 (#1197)

* Chore(deps): Bump terser-webpack-plugin from 3.1.0 to 4.2.3 (#1196)

* Chore(deps): Bump file-loader from 2.0.0 to 6.2.0 (#1194)

* Chore(deps-dev): Bump @types/react from 16.8.3 to 17.0.35 (#1219)

* Chore(deps): Bump react from 16.8.2 to 16.14.0 (#1193)

* Fix: Linting errors in snippets (#1233)

* Fix: Failure to load on Safari (Mac) (#1222)

* chore(release): 4.14.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thewahome thewahome thewahome approved these changes

@adhiambovivian adhiambovivian Awaiting requested review from adhiambovivian

@ddyett ddyett Awaiting requested review from ddyett

@millicentachieng millicentachieng Awaiting requested review from millicentachieng

@Onokaev Onokaev Awaiting requested review from Onokaev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NPS OCV pop compliance
5 participants
@ElinorW @thewahome @Onokaev @jobala @georgend