Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add overflow aria-label #1758

Merged
merged 2 commits into from
May 30, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/app/views/query-response/QueryResponse.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,9 @@ const QueryResponse = (props: IQueryResponseProps) => {
height: '100%'
}}>

<Pivot overflowBehavior="menu" onLinkClick={handlePivotItemClick}
<Pivot overflowBehavior='menu'
overflowAriaLabel={translateMessage('More items')}
onLinkClick={handlePivotItemClick}
className={'pivot-response'} >
{getPivotItems()}
<PivotItem
Expand Down
1 change: 1 addition & 0 deletions src/app/views/query-runner/request/Request.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,7 @@ export class Request extends Component<IRequestComponent, any> {
<div className='query-request'>
<Pivot
overflowBehavior='menu'
overflowAriaLabel={translateMessage('More items')}
onLinkClick={this.handlePivotItemClick}
className='pivot-request'
selectedKey={pivot}
Expand Down
5 changes: 4 additions & 1 deletion src/app/views/sidebar/Sidebar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,10 @@ export const Sidebar = (props: ISidebar) => {

return (
<div>
<Pivot onLinkClick={onPivotItemClick} overflowBehavior='menu' defaultSelectedKey={props.currentTab}>
<Pivot onLinkClick={onPivotItemClick}
overflowBehavior='menu'
overflowAriaLabel={translateMessage('More items')}
defaultSelectedKey={props.currentTab}>
<PivotItem
headerText={translateMessage('Sample Queries')}
itemIcon='Rocket'
Expand Down
3 changes: 2 additions & 1 deletion src/messages/GE.json
Original file line number Diff line number Diff line change
Expand Up @@ -436,5 +436,6 @@
"Delete collection": "Delete collection",
"Leverage libraries": "Leverage the power of our client libraries. Download the",
"Client library": "client library here ",
"SDKs documentation": "To read more about our SDKs, go to the documentation page at "
"SDKs documentation": "To read more about our SDKs, go to the documentation page at ",
"More items": "More items"
}