Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Autocomplete filter #2432

Merged
merged 8 commits into from
Mar 9, 2023
Merged

Fix: Autocomplete filter #2432

merged 8 commits into from
Mar 9, 2023

Conversation

Onokaev
Copy link
Contributor

@Onokaev Onokaev commented Mar 3, 2023 •
edited
Loading

Overview

Fixes #2431

Demo

Optional. Screenshots, curl examples, etc.

Notes

Testing Instructions

  • How to test this PR
    Type a query like /messages?$filter
    Notice that all filters added can be typed without issues

@Onokaev Onokaev marked this pull request as draft March 6, 2023 07:56
@Onokaev Onokaev requested a review from gavinbarron March 7, 2023 09:15
@Onokaev Onokaev marked this pull request as ready for review March 7, 2023 09:15
@gavinbarron
Copy link
Member

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs Vulnerability A 0 Vulnerabilities Security Hotspot A 0 Security Hotspots Code Smell A 0 Code Smells

25.0% 25.0% Coverage 0.0% 0.0% Duplication

@Onokaev and @thewahome are we getting coverage reporting from the Playwright tests in SonarCloud?

@gavinbarron
Copy link
Member

What's going on with the static site deployment? @thewahome can you please look into this?

@thewahome
Copy link
Collaborator

@Onokaev and @thewahome are we getting coverage reporting from the Playwright tests in SonarCloud?

  • I am not sure there's a way to connect them. So currently it's isolated. Playwright tests have their own report separate from sonarcloud

@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2432.centralus.azurestaticapps.net

@Onokaev
Copy link
Contributor Author

Onokaev commented Mar 8, 2023

What's going on with the static site deployment? @thewahome can you please look into this?

Hey @gavinbarron. You'll have to sign in to use the static site

@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2432.centralus.azurestaticapps.net

@Onokaev Onokaev merged commit bd1076b into dev Mar 9, 2023
@sonarcloud
Copy link

sonarcloud bot commented Mar 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@thewahome thewahome mentioned this pull request Mar 10, 2023
Merged
thewahome added a commit that referenced this pull request Mar 13, 2023
@thewahome
Merge pull request #2450 from microsoftgraph/release/8.0.0
c1282bd 
Add a devcontainer to the repo (#2421)
Task: Add copy telemetry (#2419)
Fix: Enable code selection in Expand view (#2435)
Chore(deps): Bump loader-utils from 2.0.2 to 2.0.4 (#2433)
Chore(deps): Bump json5 from 1.0.1 to 1.0.2 (#2434)
Task: Handle claims challenge (#2422)
Fix: Update azure-pipelines.yml for Azure Pipelines (#2444)
Fix: Autocomplete filter (#2432)
@thewahome thewahome deleted the fix/autocomplete-filter branch September 27, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavinbarron gavinbarron gavinbarron approved these changes

@thewahome thewahome Awaiting requested review from thewahome

@ElinorW ElinorW Awaiting requested review from ElinorW

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typing in the query bar loses/removes every other keystroke after adding $filter query
3 participants
@Onokaev @gavinbarron @thewahome