Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: remove unused localisation content #2904

Merged
merged 7 commits into from
Jan 11, 2024
Merged

Chore: remove unused localisation content #2904

merged 7 commits into from
Jan 11, 2024

Conversation

thewahome
Copy link
Collaborator

@thewahome thewahome commented Nov 20, 2023 •
edited
Loading

Overview

Closes #2902
Closes #2870

Since the files are localized when in display, it is not useful for us to keep language strings that are not updated or in use

Demo

N/A

@thewahome thewahome requested a review from a team as a code owner November 20, 2023 14:22
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 20, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@thewahome thewahome mentioned this pull request Jan 9, 2024
Closed
ElinorW
ElinorW approved these changes Jan 10, 2024
View reviewed changes
Copy link
Collaborator

@ElinorW ElinorW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clean! ✨

@thewahome thewahome merged commit fddd114 into dev Jan 11, 2024
18 of 20 checks passed
@thewahome thewahome deleted the chore/remove-unused-localisation-content branch January 11, 2024 06:26
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 11, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElinorW ElinorW ElinorW approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove unused internationalization files Localisation pipelines are broken
2 participants
@thewahome @ElinorW