Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: show all resources #3020

Merged
merged 5 commits into from
Mar 5, 2024
Merged

Fix: show all resources #3020

merged 5 commits into from
Mar 5, 2024

Conversation

thewahome
Copy link
Collaborator

Overview

Fixes #3011

GE has been calling the DevX API openapi/tree endpoint to get the consolidated open api tree document with both versions. This leads to a huge file.

Currently the built in Javacript response.json() function truncates the content as it parses the response string to JSON. This leads to some of the children not being passed from the browser to the code hence losing some nodes along the way.

This new implementation

  • makes parallel calls to get the content of each version.
  • changes the schema so that the resources in state are grouped by the version
  • removes the function that was used to filter nodes based on their version as the items are already versioned

Demo

security/auditLog

image

security/auditLog/queries

image

Notes

Optional. Ancillary topics, caveats, alternative strategies that didn't work out, anything else.

Testing Instructions

  • Switch to beta
  • In the query input, type in security/ and confirm you get auditLog as one of the options
  • Select auditLog and add a / to trigger a new autocomplete action and confirm you get queries as one of the options

@thewahome thewahome requested a review from a team as a code owner February 28, 2024 14:21
Copy link
Contributor

github-actions bot commented Mar 1, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-3020.centralus.azurestaticapps.net

@thewahome thewahome merged commit 15184ba into dev Mar 5, 2024
19 of 20 checks passed
Copy link

sonarcloud bot commented Mar 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@adhiambovivian
Copy link
Collaborator

@thewahome what changed to trigger this bug ?

@thewahome
Copy link
Collaborator Author

It was an unknown issue that had always existed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unhidden APIs not showing up in Graph explorer
3 participants