Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Canary urls crashing #3062

Merged
merged 6 commits into from
Mar 26, 2024
Merged

Fix: Canary urls crashing #3062

merged 6 commits into from
Mar 26, 2024

Conversation

ElinorW
Copy link
Collaborator

@ElinorW ElinorW commented Mar 21, 2024 •
edited
Loading

Overview

Fixes #3063

Demo

Graph.Explorer.-.Work.-.Microsoft.Edge.2024-03-21.18-44-35.mp4

Notes

Optional. Ancillary topics, caveats, alternative strategies that didn't work out, anything else.

Testing Instructions

  • Check out PR
  • Load GE
  • Paste test link https://canary.graph.microsoft.com/testprodbetatamy-pps-offboarding/me/insights/trending
  • Click anywhere on the page and observe the page doesn't crash

@ElinorW ElinorW requested a review from a team as a code owner March 21, 2024 15:46
thewahome
thewahome previously approved these changes Mar 21, 2024
View reviewed changes
@ElinorW ElinorW requested a review from thewahome March 22, 2024 16:30
@ElinorW ElinorW requested a review from thewahome March 26, 2024 11:02
@ElinorW ElinorW merged commit 53c97bb into dev Mar 26, 2024
19 of 20 checks passed
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@ElinorW ElinorW mentioned this pull request Mar 27, 2024
Closed
ElinorW added a commit that referenced this pull request Mar 27, 2024
@ElinorW
Chore: Release 9.8.0 (#3066)
3a9efd3 
* Chore(deps): Bump follow-redirects from 1.15.0 to 1.15.6 (#3058)

* Fix: Resource path causing app to crash (#3053)

* Fix: [autocomplete] show dollar sign paths (#3052)

* Fix: Canary urls crashing (#3062)

* Bump version to 9.8.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thewahome thewahome thewahome approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Graph explorer crashing for canary endpoints
2 participants
@ElinorW @thewahome