Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use strong types in authentication module #3164

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

musale
Copy link
Contributor

@musale musale commented May 30, 2024

Overview

Use strong types in src/modules/authentication. Closes #3187

Testing Instructions

  • open any files in src/modules/authentication
  • ensure no use of any types
  • ensure npm run test passes in src/modules/authentication without fails

Some stats

before

5 any counts in 2/10 files

AuthenticationWrapper.ts:4
msal-app.ts:1

after

authentication-error-hints.ts:0
AuthenticationWrapper.spec.ts:0
AuthenticationWrapper.ts:0
authUtils.spec.ts:0
authUtils.ts:0
ClaimsChallenge.ts:0
index.ts:0
interfaces/IAuthenticationWrapper.ts:0
interfaces/IClaimsChallenge.ts:0
msal-app.ts:0

Signed-off-by: Musale Martin <martinmusale@microsoft.com>
@musale musale requested a review from a team as a code owner May 30, 2024 11:43
@ElinorW
Copy link
Collaborator

ElinorW commented May 31, 2024

This is really great!
I suggest creating an issue under this main issue: #2888
So that we can track the different areas being tackled

@thewahome thewahome merged commit 499a107 into dev Jun 7, 2024
19 of 20 checks passed
Copy link

sonarcloud bot commented Jun 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@thewahome thewahome mentioned this pull request Jun 18, 2024
thewahome added a commit that referenced this pull request Jun 18, 2024
* refactor: use strong types in authentication module (#3164)

* Chore: Dependabot upgrades - April (#3124)

* fix: remove character escape in json response formatting (#3163)

* Fix: add parameters to token request (#3218)

* Bump version to 10.2.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update src/modules/authentication with stronger types
3 participants