Fix: Add aria-labels and correct colour contrast #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thewahome
reviewed
Jul 21, 2020
| onClick={this.toggleModal} | ||
| className='share-query-btn' | ||
| iconProps={{ iconName: 'MiniExpandMirrored'}} | ||
| aria-label={'Expand response'} |
There was a problem hiding this comment.
I have noticed that you are using aria-label and ariaLabel interchangeably. Do they both work? If so, we can stick to one (aria-label)
There was a problem hiding this comment.
Yeah while reading the Fluent UI docs, under some components the say that the 'ariaLabel' is obsolete, so yeah I definitely think we should stick to aria-label
thewahome
reviewed
Jul 21, 2020
| @@ -330,6 +330,7 @@ export class SampleQueries extends Component<ISampleQueriesProps, any> { | |||
| placeholder={messages['Search sample queries']} | |||
| onChange={this.searchValueChanged} | |||
| styles={{ field: { paddingLeft: 10 } }} | |||
| ariaLabel={'Search'} | |||
There was a problem hiding this comment.
this changes to aria-label?
…fix/accessibility-support
jobala
approved these changes
Jul 21, 2020
thewahome
approved these changes
Jul 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes #495